bench: Avoid deprecated use of volatile += #24372

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2202-20 changing 1 files +1 −1

MarcoFalke commented at 4:47 PM on February 17, 2022: member
Deprecated in C++20 according to https://eel.is/c++draft/expr.ass#6 .
```
bench/examples.cpp:16:13: warning: compound assignment with ‘volatile’-qualified left operand is deprecated [-Wvolatile]
   16 |         sum += sin(d);
      |         ~~~~^~~~~~~~~
```
While C++20 is currently unsupported, I don't see any downside to a minor fixup to an example benchmark. This will also make a hypothetical C++20 patch smaller.
bench: Avoid deprecated use of volatile += 9999f891d1
MarcoFalke commented at 4:49 PM on February 17, 2022: member

Can be tested with #24169 or by looking at the CI output: https://cirrus-ci.com/task/6478320643604480?logs=ci#L3123
MarcoFalke commented at 5:05 PM on February 17, 2022: member

On my system this doesn't change the binary with g++ -O2, but it does with clang++ -O2.
DrahtBot added the label Tests on Feb 17, 2022
RandyMcMillan referenced this in commit 786a5e6ba4 on Feb 18, 2022
RandyMcMillan cross-referenced this on Feb 18, 2022 from issue refactor: base58.cpp - preemptively remove deprecated += by RandyMcMillan
fanquake approved
fanquake commented at 11:29 AM on February 23, 2022: member

ACK 9999f891d1c9093e552492cf8ccc3168370c7a39
fanquake merged this on Feb 23, 2022
fanquake closed this on Feb 23, 2022
MarcoFalke deleted the branch on Feb 23, 2022
sidhujag referenced this in commit 4592c3f1bb on Feb 23, 2022
PastaPastaPasta referenced this in commit 5e4db4ea26 on Apr 7, 2022
PastaPastaPasta referenced this in commit 7e598dd632 on Apr 11, 2022
bitcoin locked this on Feb 23, 2023

Contributors

MarcoFalke

fanquake

Labels

Tests

Linked (view graph)

#24169 build: Add --enable-c++20 option #24379 refactor: base58.cpp - preemptively remove deprecated +=