uint256::begin() returns unsigned data, so there is no reason to make it signed.
Fix that and remove the sanitizer suppression.
zmq: Fix implicit-integer-sign-change #24218
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2201-zmqInt changing 2 files +6 −5-
MarcoFalke commented at 3:54 PM on January 31, 2022: member
-
zmq: Fix implicit-integer-sign-change fa2406a50a
- MarcoFalke added the label Refactoring on Jan 31, 2022
- MarcoFalke added the label RPC/REST/ZMQ on Jan 31, 2022
- hebasto approved
-
hebasto commented at 4:55 PM on January 31, 2022: member
ACK fa2406a50a83184d101d1bb3f2b282ae280370ba
uint256::begin() returns unsigned data
https://github.com/bitcoin/bitcoin/blob/0ff13913287b3874e305535c78bc43b190217168/src/uint256.h#L60
why not just
unsigned char data[32];? -
MarcoFalke commented at 5:03 PM on January 31, 2022: member
why not just unsigned char data[32];?
- It is more typing
- It is the same (see assumptions)
-
DrahtBot commented at 8:41 PM on January 31, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #23962 (Use int32_t type for transaction size/weight consistently by hebasto)
- #17786 (refactor: Nuke policy/fees->mempool circular dependencies by hebasto)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot cross-referenced this on Jan 31, 2022 from issue Use `int32_t` type for most transaction size/weight values by hebasto
- PastaPastaPasta approved
-
PastaPastaPasta commented at 5:12 AM on February 1, 2022: contributor
utACK fa2406a50a83184d101d1bb3f2b282ae280370ba, I have reviewed the code and think it makes sense
- DrahtBot cross-referenced this on Feb 1, 2022 from issue refactor: Nuke policy/fees->mempool circular dependencies by hebasto
- MarcoFalke merged this on Feb 1, 2022
- MarcoFalke closed this on Feb 1, 2022
- MarcoFalke deleted the branch on Feb 1, 2022
- sidhujag referenced this in commit bec0b57409 on Feb 1, 2022
- Fabcien referenced this in commit 410613b0ae on Dec 9, 2022
- bitcoin locked this on Feb 1, 2023
Contributors
Labels