Fix unsigned integer overflow in tapscript validation weight calculation #24217

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2201-tapscriptInt changing 1 files +2 −2

MarcoFalke commented at 3:41 PM on January 31, 2022: member

Change the tapscript validation weight constants from uint64_t to int64_t, since the type of m_validation_weight_left is also int64_t. Otherwise this will cause sanitizer warnings.

This should be safe because signed integer overflow isn't expected to happen.
Fix unsigned integer overflow in tapscript validation weight calculation fadc54b79b
MarcoFalke cross-referenced this on Jan 31, 2022 from issue Fix unsigned integer overflows in interpreter by MarcoFalke
MarcoFalke commented at 3:50 PM on January 31, 2022: member

On my system, this commit doesn't change the binary for gcc with O2, but it does change it for clang
DrahtBot added the label Consensus on Jan 31, 2022
PastaPastaPasta approved
PastaPastaPasta commented at 5:13 AM on February 1, 2022: contributor

utACK fadc54b79b14ba0bbdcf5eff1277295851fe7a9e
MarcoFalke commented at 10:39 AM on February 1, 2022: member

centos 8 CI failure can be ignored
theStack approved
theStack commented at 12:28 PM on February 1, 2022: contributor

Code-review ACK fadc54b79b14ba0bbdcf5eff1277295851fe7a9e

For reference, these are the only instances where the constants VALIDATION_WEIGHT_{PER_SIGOP_PASSED,OFFSET} are used: https://github.com/bitcoin/bitcoin/blob/133f73e86bd7c3114263500be2fb5090dd76b4bc/src/script/interpreter.cpp#L386 https://github.com/bitcoin/bitcoin/blob/133f73e86bd7c3114263500be2fb5090dd76b4bc/src/script/interpreter.cpp#L1953
luke-jr approved
luke-jr commented at 8:53 PM on February 5, 2022: member

utACK
MarcoFalke merged this on Feb 7, 2022
MarcoFalke closed this on Feb 7, 2022
MarcoFalke deleted the branch on Feb 7, 2022
sidhujag referenced this in commit 60fac3010d on Feb 7, 2022
bitcoin locked this on Feb 7, 2023

Contributors

Labels

Linked (view graph)

#24214 Fix unsigned integer overflows in interpreter