Followups for getdeploymentinfo #24187

1. 
   ajtowns commented at 7:32 AM on January 28, 2022: contributor

   Documentation, comments and trivial code changes to followup #23508.

2. ajtowns cross-referenced this on Jan 28, 2022 from issue Add getdeploymentinfo RPC by ajtowns
3. in doc/release-notes-23508.md:11 in 30572275c4 outdated

      6 | +  block, rather than just at the chain tip. Inclusion of soft fork
      7 | +  status in `getblockchaininfo` can currently be restored using the
      8 | +  configuration `-deprecatedrpc=softforks`, but this will be removed in
      9 | +  a future release. Note that in either case, the `status` field
     10 | +  now reflects the status of the current block rather than the next
     11 | +  block. (#23508)
   

   ---

   ---

   

   MarcoFalke commented at 7:49 AM on January 28, 2022:

   could move to the main file to avoid having to do it later? (This should be the last snippet for the next release)

4. 
   MarcoFalke commented at 7:50 AM on January 28, 2022: member

   Maybe also #23508 (review) ?

5. ajtowns added this to the milestone 23.0 on Jan 28, 2022
6. doc: getdeploymentinfo release notes tweaks 555eafa793
7. rpc documentation improvements 32f04e6da9
8. trivial: comment tweaks 5179656ef8
9. rpc/blockchain: a constant craving fbab43f169
10. ajtowns force-pushed on Jan 28, 2022
11. 
    ajtowns commented at 8:14 AM on January 28, 2022: contributor

    Was leaving the SoftForkPushBackDesc argument name change 'til other work that would also touch that, but meh, added.

12. MarcoFalke approved
13. 
    MarcoFalke commented at 8:21 AM on January 28, 2022: member

    LGTM

14. MarcoFalke added the label Refactoring on Jan 28, 2022
15. 
    luke-jr commented at 3:36 AM on January 31, 2022: member

    We haven't used the variable style behind pindex for years now. Why rename to it?

16. 
    Sjors commented at 2:42 PM on January 31, 2022: member

    We haven't used the variable style behind pindex for years now. Why rename to it?

    We can name it something else (as long as it's clear we're not necessarily dealing with the tip). block_index or just index (I used the latter in the getblockfrompeer RPC code)?

17. rpc/blockchain: rename getdeploymentinfo tip/active_chain_tip to blockindex e5f0356e3f
18. ajtowns force-pushed on Feb 4, 2022
19. 
    ajtowns commented at 3:50 AM on February 4, 2022: contributor

    Changed to blockindex.

20. 
    DrahtBot commented at 5:44 AM on February 4, 2022: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #24118 (Add 'sweepwallet' RPC by Xekyo)
    • #21702 (Implement BIP-119 Validation (CheckTemplateVerify) by JeremyRubin)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

21. 
    JeremyRubin commented at 6:32 AM on February 4, 2022: contributor

    shrug about renaming tip, easy enough to fix the conflict either way.

22. 
    Sjors commented at 8:58 AM on February 4, 2022: member

    utACK e5f0356e3ffea10f447998b7549a67e016446e81 @JeremyRubin a rebase beats an off by one soft fork activation error due to unreadable activation-related code :-)

23. DrahtBot cross-referenced this on Feb 4, 2022 from issue Implement BIP-119 Validation (CheckTemplateVerify) by JeremyRubin
24. DrahtBot cross-referenced this on Feb 11, 2022 from issue Add 'sendall' RPC née sweep by murchandamus
25. MarcoFalke merged this on Feb 14, 2022
26. MarcoFalke closed this on Feb 14, 2022

    ---

27. sidhujag referenced this in commit 2d957724f7 on Feb 14, 2022
28. bitcoin locked this on Feb 14, 2023

Contributors

ajtownsMarcoFalkeluke-jrSjorsDrahtBotJeremyRubin

Milestone
23.0