rpc/doc: describe using combo(privkey) to get checksum and then list … #24161

pull kallewoof wants to merge 1 commits into bitcoin:master from kallewoof:202201-derivefromprivkey changing 1 files +9 −2
  1. kallewoof commented at 5:46 AM on January 26, 2022: member

    …addresses via descriptor calls.

    This is not obvious, so deserves some documentation. It might be worth it to also add a 'don't care about checksum' flag to deriveaddresses to avoid the getdescriptorinfo step.

    See #24160, #24162.

  2. kallewoof cross-referenced this on Jan 26, 2022 from issue rpc: add require_checksum flag to deriveaddresses by kallewoof
  3. DrahtBot added the label RPC/REST/ZMQ on Jan 26, 2022
  4. shaavan commented at 11:53 AM on January 26, 2022: contributor

    Concept 0 in favor of #24162

    As explained by @kallewoof here, the private key is in WIF format, which has checksum included in it. This two-step behavior of first deriving the checksum and then the addresses is hence redundant.

    So I think instead of providing documentation for the current behavior, its better to fix this redundancy which is being done in #24162

  5. DrahtBot commented at 11:44 PM on January 26, 2022: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    No conflicts as of last run.

  6. luke-jr commented at 2:26 AM on January 31, 2022: member

    Concept NACK. There's really no good reason to use the same private key for multiple different addresses, is there?

  7. kallewoof commented at 3:39 AM on January 31, 2022: member

    There are good reasons to use the same privkey for multiple different addresses. One of them is unit testing / test vectors for some application that uses addresses (e.g. BIP-322).

    Edit: besides, all this does is describe how to do it, the functionality itself is already there.

  8. DrahtBot cross-referenced this on May 3, 2022 from issue rpc: Move output script RPCs to separate file, rename misc.cpp by maflcko
  9. DrahtBot added the label Needs rebase on May 4, 2022
  10. rpc/doc: describe using combo(privkey) to get checksum and then list addresses via descriptor calls 523e51feea
  11. kallewoof force-pushed on May 6, 2022
  12. DrahtBot removed the label Needs rebase on May 6, 2022
  13. DrahtBot cross-referenced this on May 7, 2022 from issue descriptors: Be able to specify change and receiving in a single descriptor string by achow101
  14. DrahtBot cross-referenced this on May 12, 2022 from issue tidy: use modernize-use-raw-string-literal by fanquake
  15. kallewoof closed this on Apr 11, 2023

  16. kallewoof deleted the branch on Apr 11, 2023
  17. bitcoin locked this on Apr 10, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:53 UTC