The "flags" parameter is used to decide whether to use MTP or network adjusted time. Make the wallet use MTP instead of adjusted time.
Otherwise this might calculate the wrong wallet balance or list the wrong coins.
wallet: Use MTP for locktime checks, not adjusted time #24038
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2201-lockstuff changing 4 files +41 −2-
MarcoFalke commented at 3:21 PM on January 11, 2022: member
- MarcoFalke marked this as a draft on Jan 11, 2022
- MarcoFalke force-pushed on Jan 11, 2022
- DrahtBot added the label interfaces on Jan 11, 2022
- DrahtBot added the label RPC/REST/ZMQ on Jan 11, 2022
- DrahtBot added the label Validation on Jan 11, 2022
- DrahtBot added the label Wallet on Jan 11, 2022
-
DrahtBot commented at 5:29 PM on January 11, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #20892 (tests: Run both descriptor and legacy tests within a single test invocation by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot cross-referenced this on Jan 11, 2022 from issue document and clean up MaybeUpdateMempoolForReorg by glozow
- DrahtBot cross-referenced this on Jan 11, 2022 from issue refactor: Move calculation logic out from `CheckSequenceLocksAtTip()` by hebasto
- MarcoFalke removed the label RPC/REST/ZMQ on Jan 13, 2022
- MarcoFalke removed the label Validation on Jan 13, 2022
- MarcoFalke removed the label interfaces on Jan 13, 2022
- MarcoFalke added the label Refactoring on Jan 13, 2022
- MarcoFalke marked this as ready for review on Jan 13, 2022
- MarcoFalke force-pushed on Jan 13, 2022
- MarcoFalke renamed this:
wallet: Enforce BIP68
wallet: Use MTP for locktime checks, not adjusted time
on Jan 13, 2022 -
luke-jr commented at 6:16 PM on January 13, 2022: member
Concept ACK, but maybe while you're renaming, we should make it do
CheckSequenceLocksas well? - MarcoFalke removed the label Refactoring on Jan 13, 2022
- MarcoFalke added the label Bug on Jan 13, 2022
- MarcoFalke force-pushed on Jan 13, 2022
- MarcoFalke force-pushed on Jan 13, 2022
-
wallet: Use MTP for locktime checks, not adjusted time fa0411993f
- MarcoFalke force-pushed on Jan 13, 2022
- MarcoFalke force-pushed on Jan 13, 2022
- MarcoFalke force-pushed on Jan 13, 2022
-
MarcoFalke commented at 7:32 PM on January 13, 2022: member
Concept ACK, but maybe while you're renaming, we should make it do CheckSequenceLocks as well?
Thanks, I've edited the scripted diff, but I am including this in a follow-up refactor to keep the bugfix patch minimal.
-
MarcoFalke commented at 7:49 PM on January 13, 2022: member
The included regression test can be tested by observing a failure when running against current master
-
luke-jr commented at 8:35 PM on January 13, 2022: member
But without CheckSequenceLocks, this is only a partial fix, and the bug remains...?
-
MarcoFalke commented at 10:58 AM on January 14, 2022: member
- MarcoFalke marked this as a draft on Jan 14, 2022
- DrahtBot cross-referenced this on Jan 14, 2022 from issue tests: Run both descriptor and legacy tests within a single test invocation by achow101
- MarcoFalke closed this on Jan 14, 2022
- MarcoFalke deleted the branch on Jan 14, 2022
- MarcoFalke cross-referenced this on Jan 16, 2022 from issue policy: Remove unused locktime flags by MarcoFalke
- bitcoin locked this on Jan 14, 2023
