refactor: add thread safety lock assertion to WriteBlockIndexDB() #24002

pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:add-thread-safety-lock-assertion-to-WriteBlockIndexDB changing 1 files +1 −0
  1. jonatack commented at 12:16 PM on January 7, 2022: contributor

    New helper function BlockManager::WriteBlockIndexDB() added in #23974 has a thread safety lock annotation in its declaration but is missing the corresponding run-time lock assertion in its definition.

    Per doc/developer-notes.md: "Combine annotations in function declarations with run-time asserts in function definitions."

  2. refactor: add thread safety lock assertion to WriteBlockIndexDB()
    The new helper function, BlockManager::WriteBlockIndexDB(),
has a thread safety lock annotation in its declaration but is
missing the corresponding run-time lock assertion in its definition.

Per doc/developer-notes.md: "Combine annotations in function
declarations with run-time asserts in function definitions."
    1823766fc6
  3. jonatack cross-referenced this on Jan 7, 2022 from issue Make blockstorage globals private members of BlockManager by MarcoFalke
  4. fanquake commented at 12:23 PM on January 7, 2022: member

    Combine into #22932 once it's rebased?

  5. jonatack commented at 12:29 PM on January 7, 2022: contributor

    Combine into #22932 once it's rebased?

    This code doesn't touch that pull. (It's also been open for several months without ACKs, so I'm planning to split it up into smaller pulls to ease review.)

  6. fanquake commented at 12:36 PM on January 7, 2022: member

    This code doesn't touch that pull.

    That would be difficult given the code modified here has only been added to the repo since that PR was last rebased. I suggested combining because #22932 is full of changes very similar to this one.

  7. jonatack commented at 12:50 PM on January 7, 2022: contributor

    #22932 does not touch this function and there is no guarantee that it will be merged. I plan to reduce its scope or perhaps close it.

  8. DrahtBot added the label Block storage on Jan 7, 2022
  9. DrahtBot added the label Refactoring on Jan 7, 2022
  10. DrahtBot commented at 1:59 AM on January 8, 2022: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #22564 ([WIP] refactor: Move mutable globals cleared in ::UnloadBlockIndex to BlockManager by dongcarl)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  11. DrahtBot cross-referenced this on Jan 8, 2022 from issue refactor: Move mutable globals cleared in `::UnloadBlockIndex` to `BlockManager` by dongcarl
  12. MarcoFalke commented at 8:08 AM on January 8, 2022: member

    cr ACK 1823766fc69a3d57767af11f182826533465f621

  13. MarcoFalke merged this on Jan 8, 2022
  14. MarcoFalke closed this on Jan 8, 2022
  15. jonatack deleted the branch on Jan 8, 2022
  16. sidhujag referenced this in commit 191608dff8 on Jan 9, 2022
  17. bitcoin locked this on Jan 8, 2023
Contributors
jonatackfanquakeDrahtBotMarcoFalke
Labels
RefactoringBlock storage
Linked (view graph)
#22392 scripts: use LIEF for ELF security & symbol checks#22932 Add CBlockIndex lock annotations, guard nStatus/nFile/nDataPos/nUndoPos by cs_main#23974 Make blockstorage globals private members of BlockManager
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:53 UTC