test: set ban after mocking time #23996

pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2022-01-fix-ban-mocktime changing 1 files +2 −2

brunoerg commented at 7:27 PM on January 6, 2022: contributor

Fixes #23988

Set ban after mocking time to avoid intermittent failures related to the assertion of ban_duration and time_remaining.

See: https://cirrus-ci.com/task/6754020390862848?logs=ci#L4652
test: set ban after mocking time c9374af102
DrahtBot added the label Tests on Jan 6, 2022
mzumsande commented at 9:52 PM on January 6, 2022: contributor

Tested ACK c9374af10227be3e4c9d4fb5fbd1027841361f14

You could add to the PR description that this fixes #23988 , so that issue will get closed.
brunoerg commented at 9:56 PM on January 6, 2022: contributor

You could add to the PR description that this fixes #23988 , so that issue will get closed. Thanks, I didn't know that opened issue, only the comment on that PR.
vincenzopalazzo approved
vincenzopalazzo commented at 11:32 PM on January 6, 2022: none

ACK https://github.com/bitcoin/bitcoin/pull/23996/commits/c9374af10227be3e4c9d4fb5fbd1027841361f14
fanquake merged this on Jan 6, 2022
fanquake closed this on Jan 6, 2022
vasild commented at 9:17 AM on January 7, 2022: contributor

ACK c9374af10227be3e4c9d4fb5fbd1027841361f14
vasild cross-referenced this on Jan 7, 2022 from issue test: check ban_duration and time_remaining after setting ban by brunoerg
sidhujag referenced this in commit 1d6828e071 on Jan 7, 2022
bitcoin locked this on Jan 7, 2023

Contributors

Labels