ci: failure in feature_startupnotify.py #23967

issue fanquake opened this issue on January 4, 2022

fanquake commented at 1:36 AM on January 4, 2022: member

Seen in https://cirrus-ci.com/task/6190790023053312?logs=functional_tests#L381 in the Win64 job:

 node0 2022-01-03T17:55:20.863953Z [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\util\thread.cpp:17] [TraceThread] msghand thread start 
 test  2022-01-03T17:55:20.870000Z TestFramework.node0 (DEBUG): RPC successfully started 
 test  2022-01-03T17:55:20.870000Z TestFramework (ERROR): Assertion failed 
                                   Traceback (most recent call last):
                                     File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_framework\test_framework.py", line 132, in main
                                       self.run_test()
                                     File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\feature_startupnotify.py", line 29, in run_test
                                       assert os.path.exists(tmpdir_file)
                                   AssertionError
 test  2022-01-03T17:55:20.870000Z TestFramework (DEBUG): Closing down network thread

fanquake added the label Tests on Jan 4, 2022
MarcoFalke commented at 8:17 AM on January 4, 2022: member

Yeah, that should be a wait_until, not assert

ryanofsky commented at 5:58 PM on January 4, 2022: contributor

Saw another instance, not on windows

https://cirrus-ci.com/task/5158961778262016?logs=ci#L7630

2022-01-03T21:34:26.388000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_startupnotify.py", line 29, in run_test
    assert os.path.exists(tmpdir_file)
AssertionError

fanquake referenced this in commit 96eb0093d0 on Jan 5, 2022
fanquake cross-referenced this on Jan 5, 2022 from issue test: wait for rather than assert presence of file in startupnotify test by fanquake
MarcoFalke referenced this in commit 45ed459f95 on Jan 5, 2022
MarcoFalke closed this on Jan 5, 2022
sidhujag referenced this in commit 1ff7a41957 on Jan 6, 2022
mzumsande referenced this in commit 13a7ce5711 on Jan 17, 2022
rebroad referenced this in commit 87cbe2a5d9 on Feb 3, 2022

fanquake commented at 5:22 PM on February 28, 2022: member

Seen this again https://cirrus-ci.com/task/4803606300852224:

 test  2022-02-28T17:08:11.001000Z TestFramework (INFO): Test -startupnotify is executed once 
 test  2022-02-28T17:08:11.001000Z TestFramework (ERROR): Assertion failed 
                                   Traceback (most recent call last):
                                     File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_framework\test_framework.py", line 132, in main
                                       self.run_test()
                                     File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\feature_startupnotify.py", line 34, in run_test
                                       assert_equal(file_content.count(FILE_NAME), 1)
                                     File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_framework\util.py", line 51, in assert_equal
                                       raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
                                   AssertionError: not(0 == 1)
 test  2022-02-28T17:08:11.001000Z TestFramework (DEBUG): Closing down network thread 
 test  2022-02-28T17:08:11.001000Z TestFramework (INFO): Stopping nodes 
 test  2022-02-28T17:08:11.001000Z TestFramework.node0 (DEBUG): Stopping node

jonatack cross-referenced this on Jul 19, 2022 from issue Intermittent failure in feature_startupnotify.py by jonatack
bitcoin locked this on Feb 28, 2023

Contributors

Labels

Linked (view graph)

#23979 test: wait for rather than assert presence of file in startupnotify test #25644 Intermittent failure in feature_startupnotify.py