test: use MiniWallet for p2p_compactblocks.py #23873

pull theStack wants to merge 1 commits into bitcoin:master from theStack:202112-test-use_MiniWallet_for_p2p_compactblocks changing 1 files +5 −9
  1. theStack commented at 1:53 PM on December 27, 2021: contributor

    This PR enables one more of the non-wallet functional tests (p2p_compactblocks.py) to be run even with the Bitcoin Core wallet disabled by using the MiniWallet instead, as proposed in #20078.

    The wallet RPCs calls (getnewaddress/sendtoaddress) can easily be substituted by generating/sending to the MiniWallet's internal address instead (self.generate(self.wallet, ...)/self.wallet.send_self_transfer(...)).

  2. test: use MiniWallet for p2p_compactblocks.py
    This test can now be run even with the Bitcoin Core wallet disabled.
    d2efb66458
  3. DrahtBot added the label Tests on Dec 27, 2021
  4. josibake approved
  5. josibake commented at 4:06 PM on December 27, 2021: contributor

    ACK https://github.com/bitcoin/bitcoin/pull/23873/commits/d2efb66458e5ded38fe15216710de7036fe55244

    ran test without wallet enabled, worked as expected :tada:

  6. brunoerg approved
  7. brunoerg commented at 5:33 PM on December 27, 2021: contributor

    tACK d2efb66458e5ded38fe15216710de7036fe55244

    worked without wallet!

  8. DrahtBot commented at 5:20 AM on December 28, 2021: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #23127 (tests: Use test framework utils where possible by vincenzopalazzo)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  9. DrahtBot cross-referenced this on Dec 28, 2021 from issue tests: Use test framework utils where possible by vincenzopalazzo
  10. MarcoFalke merged this on Dec 28, 2021
  11. MarcoFalke closed this on Dec 28, 2021

  12. theStack deleted the branch on Dec 28, 2021
  13. sidhujag referenced this in commit 259836eb4e on Dec 28, 2021
  14. shommel cross-referenced this on Apr 22, 2022 from issue test: Convert non-wallet tests to use our python MiniWallet by MarcoFalke
  15. bitcoin locked this on Dec 28, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:53 UTC