doc: Fix -changetype help text #23840

1. 
   MarcoFalke commented at 10:13 AM on December 22, 2021: member

   This was forgotten in commit 3ac38058ce0e80a9f4276bfa82951decdb237e9a

2. doc: Fix -changetype help text

   This was forgotten in commit 3ac38058ce0e80a9f4276bfa82951decdb237e9a

   fa993d0e7e
3. MarcoFalke cross-referenced this on Dec 22, 2021 from issue wallet: Strictly match tx change type to improve privacy by MarcoFalke
4. shaavan approved
5. 
   shaavan commented at 10:42 AM on December 22, 2021: contributor

   ACK fa993d0e7e4d27ca1cf7d88a5a6ec5b93b7ed503

   The updated docs match the implementation changes done in 3ac38058ce0e80a9f4276bfa82951decdb237e9a

   The updated docs tell about the default value of -changetype (i.e., legacy). And all the non-default behavior is implied by “else it is an implementation detail.” I especially like using this phrasing because:

   1. A non-tech savvy user wouldn’t like (or need) to know all the implementation details.
   2. A tech-savvy user is pointed in the right direction to find the details.
   3. Save precious space on the terminal when this text is displayed through –help command.

   Tested successfully on Ubuntu 20.04 using the command:

   ./src/bitcoin –help
   

   Master	PR

6. DrahtBot added the label Wallet on Dec 22, 2021
7. MarcoFalke added the label Docs on Dec 22, 2021
8. fanquake requested review from achow101 on Dec 23, 2021
9. w0xlt approved
10. 
    w0xlt commented at 10:35 AM on December 23, 2021: contributor

    ACK fa993d0

11. josibake approved
12. 
    josibake commented at 4:10 PM on December 27, 2021: contributor

    ACK https://github.com/bitcoin/bitcoin/pull/23840/commits/fa993d0e7e4d27ca1cf7d88a5a6ec5b93b7ed503

13. fanquake merged this on Dec 28, 2021
14. fanquake closed this on Dec 28, 2021

    ---

15. MarcoFalke deleted the branch on Dec 28, 2021
16. sidhujag referenced this in commit bf1b5ea8e6 on Dec 28, 2021
17. bitcoin locked this on Dec 28, 2022

Contributors

MarcoFalkeshaavanw0xltjosibake

Review Requested
achow101