test: Fix `system_tests/run_command` on Windows #23781

pull hebasto wants to merge 4 commits into bitcoin:master from hebasto:211215-bptest changing 1 files +34 −28

hebasto commented at 12:09 PM on December 15, 2021: member

An attempt to fix bitcoin/bitcoin#23775.

With this PR on Windows 10 Pro 21H1 (build 19043.1348):

C:\Users\hebasto\bitcoin>src\test_bitcoin.exe --run_test=system_tests/run_command
Running 1 test case...

*** No errors detected

C:\Users\hebasto\bitcoin>src\test_bitcoin.exe
Running 482 test cases...

*** No errors detected

test: Fix "echo" subtest in the system_tests for Windows 507c009c1e
test: Fix "false" subtest in system_tests for Windows 0aad33db64
test: Fix "non-zero exit code" subtest in system_tests for Windows fb1b0590af
test: Improve "invalid_command" subtest in system_tests for Windows
No need to explain code with comments.
edd0313ae7
hebasto marked this as ready for review on Dec 15, 2021
hebasto cross-referenced this on Dec 15, 2021 from issue Fatal Error: test_bitcoin.exe --run_test=system_tests Built in Visual Studio Community 2019 by Tru3Nrg
DrahtBot added the label Tests on Dec 15, 2021
sipsorcery commented at 8:34 PM on December 15, 2021: member

tACK edd0313ae7c94420642081c9172e349080bb9335
hebasto added the label Windows on Dec 16, 2021
Tru3Nrg commented at 12:55 AM on December 17, 2021: none

tACK https://github.com/bitcoin/bitcoin/pull/23781/commits/edd0313ae7c94420642081c9172e349080bb9335 that solves #23775
laanwj merged this on Dec 18, 2021
laanwj closed this on Dec 18, 2021
hebasto deleted the branch on Dec 18, 2021
sidhujag referenced this in commit 0032e8fec9 on Dec 18, 2021
bitcoin locked this on Dec 18, 2022

Contributors

Labels

Linked (view graph)

#23775 Fatal Error: test_bitcoin.exe --run_test=system_tests Built in Visual Studio Community 2019