doc: follow-ups from #23365 (index backwards search) #23777

1. 
   mzumsande commented at 9:50 PM on December 14, 2021: contributor

   This adds two explanations suggested in the review of #23365, that I didn't manage to address before that PR was merged:

   #23365 (review) #23365 (review)

2. DrahtBot added the label UTXO Db and Indexes on Dec 14, 2021
3. mzumsande cross-referenced this on Dec 14, 2021 from issue index: Fix backwards search for bestblock by mzumsande
4. fanquake requested review from jamesob on Dec 14, 2021
5. fanquake requested review from jnewbery on Dec 14, 2021
6. fanquake added the label Docs on Dec 14, 2021
7. in src/index/base.cpp:100 in 43ccaf6fdf outdated

     95 | @@ -96,6 +96,8 @@ bool BaseIndex::Init()
     96 |                      prune_violation = false;
     97 |                      break;
     98 |                  }
     99 | +                // block->pprev must exist at this point, since block_to_test is chosen such that it
    100 | +                // must be encountered when going backwards from the tip
   

   ---

   ---

   

   MarcoFalke commented at 8:40 AM on December 15, 2021:

                   // block->pprev must exist at this point, since block_to_test is part of the chain and thus
                   // must be encountered when going backwards from the tip
   

   ---

   

   mzumsande commented at 10:06 AM on December 15, 2021:

   done, thanks

8. MarcoFalke approved
9. 
   MarcoFalke commented at 8:40 AM on December 15, 2021: member

   ACK, left a nit (can be ignored)

10. doc: add explanations for assert in index and magic numbers in test

    These were suggested in review of #23365
    
    Co-authored-by: John Newbery <john@johnnewbery.com>

    e4a8d561ed
11. mzumsande force-pushed on Dec 15, 2021
12. 
    jnewbery commented at 11:18 AM on December 15, 2021: member

    ACK e4a8d561edf3cfb326e86c87155fed41a61e7333

13. MarcoFalke merged this on Dec 16, 2021
14. MarcoFalke closed this on Dec 16, 2021

    ---

15. sidhujag referenced this in commit 8eeb7d1aaf on Dec 16, 2021
16. mzumsande deleted the branch on Dec 16, 2021
17. Fabcien referenced this in commit f929502483 on Apr 5, 2022
18. bitcoin locked this on Dec 16, 2022

Contributors

mzumsandeMarcoFalkejnewbery

Review Requested
jamesobjnewbery