Assume should only be used when a failed check is recoverable. The checks here don't recover and would run into UB, so use Assert instead.
wallet: Replace Assume with Assert where needed in coinselection #23762
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2112-refAssertCoinWallet changing 1 files +3 −4-
MarcoFalke commented at 1:48 PM on December 13, 2021: member
-
wallet: Replace Assume with Assert where needed in coinselection fa26c55644
- MarcoFalke added the label Refactoring on Dec 13, 2021
- MarcoFalke cross-referenced this on Dec 13, 2021 from issue wallet: Introduce SelectionResult for encapsulating a coin selection solution by achow101
- theStack approved
-
theStack commented at 9:59 PM on December 13, 2021: contributor
Code-review ACK fa26c5564429d3201f43850afaf1b4df2ed11ad9
- luke-jr approved
-
luke-jr commented at 10:38 PM on December 13, 2021: member
utACK
- fanquake merged this on Dec 14, 2021
- fanquake closed this on Dec 14, 2021
- MarcoFalke deleted the branch on Dec 14, 2021
- bitcoin locked this on Dec 14, 2022
