Hopefully fixes #23646.
This makes a few changes to feature_init (along the lines of the discussion here: #23289 (review)). The changes are detailed in the specific commits, but a summary might be:
Could rebase over commit bf66e258a84e18935fde3ebb9a4b0392bf883222?
Thanks, concept ACK
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Are you still working on this? If not, that is fine, just let us know, so that it can be picked up.
Oh whoops, didn't see the rebase label.
This part of the test sporadically fails on CI infrastructure. Instead
of perturbing a single .ldb file of each type, move all .ldb files of a
given type to ensure a bad startup.
This test sporadically fails due to the Python test missing log lines
for reasons that are poorly understood. The problem is made worse by the
fact that this test does not retain the log files from iteration to
iteration.
Change the test to do logline detection in a more robust manner (by
using `re.search` on the whole log content) in a way that is comparable
to the existing `assert_debug_log` utility, and retain all debug.log
content from case to case.
Now that #23365 is merged.
Merging this to unbreak the CI. I am resetting too many CI build manually every day
103 | @@ -132,7 +104,8 @@ def check_clean_start():
104 | if line:
line = logfile.readline()
File "/usr/lib/python3.8/codecs.py", line 322, in decode
(result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe2 in position 0: unexpected end of data