Revert "Fixes Bug in Transaction generation in ComplexMempool benchmark" #23693

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2112-ciBench changing 1 files +8 −10

MarcoFalke commented at 1:28 PM on December 7, 2021: member

Developers are reporting crashes (potentially OOM) on IRC, but I can't reproduce. Still, revert this for now, since one developer reported the bare metal this was running on crashed.
Revert "Fixes Bug in Transaction generation in ComplexMempool benchmark"
This reverts commit 29e983386b0aecf99cdb7d0e08ba6b450bed313e.
faa185bb3a
MarcoFalke force-pushed on Dec 7, 2021
hebasto commented at 1:41 PM on December 7, 2021: member

Is it ok that this PR is not based on the master branch? I mean, a commit parent is not a merge commit.
MarcoFalke merged this on Dec 7, 2021
MarcoFalke closed this on Dec 7, 2021
MarcoFalke commented at 1:53 PM on December 7, 2021: member

Is it ok that this PR is not based on the master branch?

Huh, I think it is impossible to create a pull request for a branch that isn't based on a commit in the target branch?
MarcoFalke deleted the branch on Dec 7, 2021
jonatack cross-referenced this on Dec 7, 2021 from issue mining, refactor: add m_mempool.cs thread safety lock assertions by jonatack
MarcoFalke commented at 2:07 PM on December 7, 2021: member

I mean, a commit parent is not a merge commit.

I don't think we do or should require that. Would there be a reason?
laanwj commented at 3:34 PM on December 7, 2021: member

Thanks, tested ACK faa185bb3abe5fdaeeae14706bad9437acac6a69 Can run the bench_bitcoin again without crashing my whole computer.
sidhujag referenced this in commit 34daf9a0d0 on Dec 7, 2021
jonatack commented at 5:26 PM on December 7, 2021: contributor

ACK, with this change merged I can run the bench tests again locally on master.
RandyMcMillan referenced this in commit 15bf7c19de on Dec 23, 2021
PastaPastaPasta referenced this in commit 5acb703331 on Apr 7, 2022
PastaPastaPasta referenced this in commit 9da9f5c5bd on Apr 7, 2022
PastaPastaPasta referenced this in commit 06fcf75fde on Apr 7, 2022
PastaPastaPasta referenced this in commit 7125bfaa9c on Apr 11, 2022
MarcoFalke cross-referenced this on Apr 25, 2022 from issue bench: remove from available_coins with reference, vout size by Crypt-iQ
bitcoin locked this on Dec 7, 2022

Contributors

Linked (view graph)

#23692 mining, refactor: add m_mempool.cs thread safety lock assertions #24975 bench: remove from available_coins with reference, vout size