ci: Make macOS native task sqlite only #23682

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2112-ciSqlite changing 1 files +2 −2
  1. MarcoFalke commented at 11:06 AM on December 6, 2021: member

    There are many sqlite-only test failures (#23563, #23562), so make one CI task sqlite-only.

    Obviously this removes bdb coverage from macOS, but I don't expect this to break very often.

  2. ci: Make macOS native task sqlite only fad2e0a36a
  3. fanquake added the label Tests on Dec 6, 2021
  4. theStack commented at 11:56 AM on December 6, 2021: contributor

    Strong Concept ACK

  5. MarcoFalke commented at 12:37 PM on December 6, 2021: member

    #23684 :smiling_face_with_tear:

  6. theStack cross-referenced this on Dec 6, 2021 from issue test: fix `interface_bitcoin_cli.py --descriptors` and add to test runner by theStack
  7. fanquake commented at 12:58 AM on December 7, 2021: member

    Concept ACK

  8. Sjors commented at 5:21 AM on December 7, 2021: member

    On the one hand this seems alright, now that we're gradually deprecating BDB. But at the same time, we haven't finished the wallet upgrade tooling, which requires the presence of both.

  9. MarcoFalke commented at 7:46 AM on December 7, 2021: member

    Given that there are plenty of devs on macOS and all the remaining CI tasks also test bdb, I don't think this will cause any issues.

  10. MarcoFalke referenced this in commit 877f3aa85c on Dec 7, 2021
  11. MarcoFalke commented at 8:58 AM on December 7, 2021: member

    Blocked on #23686 (comment)

  12. DrahtBot cross-referenced this on Dec 7, 2021 from issue bench: Avoid OOM for now by MarcoFalke
  13. DrahtBot commented at 1:40 PM on December 7, 2021: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    No conflicts as of last run.

  14. theStack cross-referenced this on Dec 8, 2021 from issue test: interface_bitcoin_cli.py: check specified wallet type availability by theStack
  15. MarcoFalke referenced this in commit f727d814bd on Dec 8, 2021
  16. MarcoFalke commented at 5:59 PM on December 8, 2021: member

    next failure:

    2021-12-08T17:56:13.138000Z TestFramework (ERROR): JSONRPC error
    Traceback (most recent call last):
      File "/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin19/test/functional/test_framework/test_framework.py", line 132, in main
        self.run_test()
      File "/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin19/test/functional/feature_rbf.py", line 79, in run_test
        self.test_rpc()
      File "/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin19/test/functional/feature_rbf.py", line 542, in test_rpc
        self.init_wallet(node=0)
      File "/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin19/test/functional/test_framework/test_framework.py", line 433, in init_wallet
        n.createwallet(wallet_name=wallet_name, descriptors=self.options.descriptors, load_on_startup=True)
      File "/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin19/test/functional/test_framework/test_node.py", line 704, in createwallet
        return self.__getattr__('createwallet')(wallet_name, disable_private_keys, blank, passphrase, avoid_reuse, descriptors, load_on_startup, external_signer)
      File "/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin19/test/functional/test_framework/coverage.py", line 49, in __call__
        return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
      File "/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin19/test/functional/test_framework/authproxy.py", line 144, in __call__
        raise JSONRPCException(response['error'], status)
    test_framework.authproxy.JSONRPCException: Compiled without bdb support (required for legacy wallets) (-4)
    
  17. theStack cross-referenced this on Dec 8, 2021 from issue test: feature_rbf.py: check specified wallet type availability by theStack
  18. luke-jr commented at 2:28 AM on December 9, 2021: member

    Why not remove it from one of the Linux tasks instead?

  19. MarcoFalke commented at 8:25 AM on December 9, 2021: member

    Why not remove it from one of the Linux tasks instead?

    Why, and which one? They'd also loose coverage, since we run Linux with sanitizers enabled.

  20. MarcoFalke referenced this in commit 529ed33362 on Dec 9, 2021
  21. MarcoFalke commented at 12:56 PM on December 9, 2021: member

    next failure:

     test  2021-12-09T10:13:33.507000Z TestFramework (ERROR): Assertion failed 
                                       Traceback (most recent call last):
                                         File "/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin/test/functional/test_framework/test_framework.py", line 132, in main
                                           self.run_test()
                                         File "/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin/test/functional/feature_coinstatsindex.py", line 51, in run_test
                                           self._test_coin_stats_index()
                                         File "/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin/test/functional/feature_coinstatsindex.py", line 176, in _test_coin_stats_index
                                           assert_equal(res6['block_info'], {
                                         File "/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin/test/functional/test_framework/util.py", line 50, in assert_equal
                                           raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
                                       AssertionError: not(
    {'prevout_spent': Decimal('111.00000000'), 'coinbase': Decimal('50.01006620'), 'new_outputs_ex_coinbase': Decimal('89.99993380'), 'unspendable': Decimal('20.99000000'), 'unspendables': {'genesis_block': Decimal('0E-8'), 'bip30': Decimal('0E-8'), 'scripts': Decimal('20.99000000'), 'unclaimed_rewards': Decimal('0E-8')}} == 
    {'unspendable': Decimal('20.99000000'), 'prevout_spent': 111, 'new_outputs_ex_coinbase': Decimal('89.99993620'), 'coinbase': Decimal('50.01006380'), 'unspendables': {'genesis_block': 0, 'bip30': 0, 'scripts': Decimal('20.99000000'), 'unclaimed_rewards': 0}})
    
  22. theStack cross-referenced this on Dec 9, 2021 from issue test: fix `feature_coinstatsindex.py --descriptors` and add to test runner by theStack
  23. MarcoFalke referenced this in commit 2f26d8ec70 on Dec 9, 2021
  24. MarcoFalke commented at 5:24 PM on December 9, 2021: member

    CI is green now

  25. fanquake approved
  26. fanquake commented at 2:21 AM on December 10, 2021: member

    ACK fad2e0a36a56222ec6284a03f374e80527701d15 - clearly worthwhile having a sqlite only CI given the amount of bugs this has turned up in the past week or so. Tested running the functional tests with a --without-bdb build on macOS and Linux.

  27. MarcoFalke merged this on Dec 10, 2021
  28. MarcoFalke closed this on Dec 10, 2021

  29. MarcoFalke deleted the branch on Dec 10, 2021
  30. sidhujag referenced this in commit b216e0f8fb on Dec 10, 2021
  31. RandyMcMillan referenced this in commit 51924900c5 on Dec 23, 2021
  32. RandyMcMillan referenced this in commit 39c53817ee on Dec 23, 2021
  33. RandyMcMillan referenced this in commit 453922b3d4 on Dec 23, 2021
  34. bitcoin locked this on Dec 10, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:53 UTC