refactor tests to fix ubsan suppressions #23629

1. 
   MarcoFalke commented at 3:21 PM on November 29, 2021: member

   The ubsan suppressions for test files have several issues:

   • They bloat the suppressions file, distracting from real bugs
   • They are file-wide, thus suppressing any other (newly introduced) issues in the same file
   • Some of them are causing compile issues with -Wimplicit-int-conversion

   Fix all issues by making the integer truncations or sign changes explicit.

   This is a refactor that shouldn't change the test binary unless compiled with sanitizers.

2. MarcoFalke added the label Tests on Nov 29, 2021
3. MarcoFalke force-pushed on Dec 2, 2021
4. MarcoFalke requested review from practicalswift on Dec 7, 2021
5. MarcoFalke force-pushed on Dec 15, 2021
6. MarcoFalke force-pushed on Jan 2, 2022
7. MarcoFalke force-pushed on Jan 2, 2022
8. 
   MarcoFalke commented at 4:08 PM on January 2, 2022: member

   Rebased for fresh CI

9. DrahtBot cross-referenced this on Jan 3, 2022 from issue Remove txmempool implicit-integer-sign-change sanitizer suppressions by MarcoFalke
10. 
    DrahtBot commented at 4:33 PM on January 3, 2022: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #23962 (Use int64_t type for transaction sizes consistently by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

11. DrahtBot cross-referenced this on Jan 4, 2022 from issue Use `int32_t` type for most transaction size/weight values by hebasto
12. laanwj added this to the "Blockers" column in a project

---

13. 
    jonatack commented at 4:57 PM on January 19, 2022: contributor

    Code review ACK fa9bab0a26b01e255d36c15c9d61219cfdbcb91c

14. refactor tests to fix ubsan suppressions faedb111d2
15. MarcoFalke force-pushed on Jan 20, 2022
16. 
    MarcoFalke commented at 2:45 PM on January 20, 2022: member

    Apologies, but I decided to force push to replace unsigned(~0x00800000) with ~0x00800000U to avoid a c-style cast where it is not needed. no other changes other than rebase

17. 
    jonatack commented at 3:51 PM on January 20, 2022: contributor

    ACK faedb111d2df78eabddaeccaba42f47572388bc7 per git range-diff 1824644a fa9bab0 faedb11 and clang 13 debug build sanity check

18. MarcoFalke merged this on Jan 20, 2022
19. MarcoFalke closed this on Jan 20, 2022

    ---

20. MarcoFalke deleted the branch on Jan 20, 2022
21. laanwj removed this from the "Blockers" column in a project

---

22. sidhujag referenced this in commit 7146b92293 on Jan 21, 2022
23. bitcoin locked this on Jan 20, 2023

Review Requested
practicalswift