build: Fix cross compiling with DEBUG=1 for Windows #23612

1. 
   hebasto commented at 2:27 PM on November 27, 2021: member

   On master (200d97faf2ed0bd0cbef93dd4bbbe77cf8fe5d13) cross compiling for Windows with depends being built with DEBUG=1 is broken in two places:

   • libbitcoinconsensus, see bitcoin/bitcoin#19772
   • libunivalue, see #22646 (comment)

   This PR workarounds both cases.

   Closes bitcoin/bitcoin#19772.

   The previous attempt was #21344.

2. build: Fix cross compiling with DEBUG=1 for Windows 36f39b487a
3. hebasto added the label Windows on Nov 27, 2021
4. hebasto added the label Build system on Nov 27, 2021
5. hebasto cross-referenced this on Nov 27, 2021 from issue build: tighter Univalue integration, remove `--with-system-univalue` by fanquake
6. laanwj requested review from fanquake on Nov 30, 2021
7. 
   laanwj commented at 6:39 PM on November 30, 2021: member

   Cannot test this at the moment. I'm confused why enable_shared=no works in this case, tagged @fanquake as reviewer because of #19772 (comment) .

8. 
   hebasto commented at 7:32 PM on November 30, 2021: member

   Cannot test this at the moment. I'm confused why enable_shared=no works in this case

   It controls how the libtool will be configured by the following ./configure script.

9. luke-jr changes_requested
10. 
    luke-jr commented at 11:07 PM on November 30, 2021: member

    Concept NACK. This doesn't fix the build, just prevents it...

11. 
    fanquake commented at 4:12 AM on December 1, 2021: member

    I agree with Luke. It's hard to call this a fix when it's just ignoring what's broken. As-is, we'd also get an undocumented special casing in our config.site, which I'd rather avoid. If this a big problem for someone, maybe we could carry this in the interim, but this isn't a long term solution, and shouldn't be merged undocumented.

12. fanquake cross-referenced this on Dec 1, 2021 from issue build: Add -fvisibility=hidden flag for macOS host by hebasto
13. CodeIsTheKey cross-referenced this on Mar 19, 2022 from issue Windows Build by CodeIsTheKey
14. fanquake cross-referenced this on Apr 25, 2022 from issue build: Make `libunivalue` a non-Libtool convenience library by hebasto
15. hebasto closed this on Apr 25, 2022

    ---

16. bitcoin locked this on Apr 25, 2023

Contributors

hebastolaanwjluke-jrfanquake

Review Requested
fanquake