Crash debug builds when mempool ConsensusScriptChecks fails #23590

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2111-crashMempool changing 1 files +2 −2
  1. MarcoFalke commented at 10:47 AM on November 25, 2021: member

    Currently a bug in the function might sneak around our testing infrastructure.

    Fix that by turning bugs into crashes during tests.

  2. Crash debug builds when mempool ConsensusScriptChecks fails faad05c6d2
  3. MarcoFalke added the label Refactoring on Nov 25, 2021
  4. MarcoFalke force-pushed on Nov 25, 2021
  5. glozow commented at 8:28 AM on November 29, 2021: member

    utACK faad05c6d2ad1840c26f6fdea7d358bf9ba6efea, there's something seriously wrong with the code if this returns false, good to throw in debug mode

  6. glozow cross-referenced this on Nov 29, 2021 from issue validation: mempool validation and submission for packages of 1 child + parents by glozow
  7. luke-jr approved
  8. luke-jr commented at 10:28 PM on November 30, 2021: member

    utACK

  9. MarcoFalke merged this on Dec 1, 2021
  10. MarcoFalke closed this on Dec 1, 2021
  11. MarcoFalke deleted the branch on Dec 1, 2021
  12. sidhujag referenced this in commit 8fb18452a7 on Dec 1, 2021
  13. RandyMcMillan referenced this in commit c4e2cc8337 on Dec 23, 2021
  14. Fabcien referenced this in commit d2f5796b2d on Nov 7, 2022
  15. bitcoin locked this on Dec 1, 2022
Contributors
MarcoFalkeglozowluke-jr
Labels
Refactoring
Linked (view graph)
#22674 validation: mempool validation and submission for packages of 1 child + parents
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:53 UTC