Bugfix: RPC/mining: Fail properly in estimatesmartfee if smart fee data is unavailable #23547 pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:fix_rpc_estimatesmartfee_nodata changing 1 files +3 −3 Conversation Commits1 Files1 Check luke-jr commented at 8:03 PM on November 18, 2021: member Fixes a regression introduced by #22722 (Not entirely sure on the solution) Bugfix: RPC/mining: Fail properly in estimatesmartfee if smart fee data is unavailable cd8d156354 MarcoFalke added this to the milestone 23.0 on Nov 18, 2021 unknown approved unknown commented at 9:16 PM on November 18, 2021: none crACK https://github.com/bitcoin/bitcoin/pull/23547/commits/cd8d156354ed32a215de5eab5c394a1d74d91ed4 DrahtBot added the label Mining on Nov 18, 2021 DrahtBot added the label RPC/REST/ZMQ on Nov 18, 2021 benthecarman commented at 8:10 PM on November 24, 2021: contributor maybe worth for 22.1 MarcoFalke removed the label Mining on Nov 25, 2021 darosior commented at 10:32 AM on December 2, 2021: member Arf, good catch.. utACK cd8d156354ed32a215de5eab5c394a1d74d91ed4 kristapsk approved kristapsk commented at 10:38 AM on December 2, 2021: contributor utACK cd8d156354ed32a215de5eab5c394a1d74d91ed4 MarcoFalke merged this on Dec 7, 2021 MarcoFalke closed this on Dec 7, 2021 MarcoFalke commented at 9:18 AM on December 7, 2021: member A regression test might be nice sidhujag referenced this in commit eb5c717d65 on Dec 7, 2021 luke-jr referenced this in commit 03cc966e25 on Dec 14, 2021 RandyMcMillan referenced this in commit f1fb7f3799 on Dec 23, 2021 bitcoin locked this on Dec 7, 2022 Contributorsluke-jrbenthecarmandarosiorkristapskMarcoFalke LabelsRPC/REST/ZMQ Milestone 23.0 Linked (view graph)#22722 rpc: update estimatesmartfee to return max of CBlockPolicyEstimator::estimateSmartFee, mempoolMinFee and minRelayTxFee