scripted-diff: Move miner to src/node #23517

pull MarcoFalke wants to merge 3 commits into bitcoin:master from MarcoFalke:2111-minerNode changing 12 files +18 −17
  1. MarcoFalke commented at 12:49 PM on November 15, 2021: member

    It is impossible to run the miner without a node (validation, chainstate, mempool, rpc, ...). Also, the module is in the node library. Thus, it should be moved to src/node.

    Also, replace the validation.h include in the header with a forward-declaration.

  2. DrahtBot added the label Build system on Nov 15, 2021
  3. DrahtBot added the label Mining on Nov 15, 2021
  4. DrahtBot added the label Refactoring on Nov 15, 2021
  5. DrahtBot added the label RPC/REST/ZMQ on Nov 15, 2021
  6. MarcoFalke removed the label Build system on Nov 15, 2021
  7. MarcoFalke removed the label RPC/REST/ZMQ on Nov 15, 2021
  8. MarcoFalke removed the label Mining on Nov 15, 2021
  9. DrahtBot commented at 5:39 AM on November 16, 2021: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #22242 (Move CBlockTreeDB to node/blockstorage by MarcoFalke)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  10. DrahtBot cross-referenced this on Nov 16, 2021 from issue scripted-diff: Move minisketchwrapper to src/node by MarcoFalke
  11. DrahtBot added the label Needs rebase on Nov 16, 2021
  12. scripted-diff: Move miner to src/node
    -BEGIN VERIFY SCRIPT-
 # Move module
 git mv src/miner.cpp src/node/
 git mv src/miner.h   src/node/
 # Replacements
 sed -i 's:miner\.h:node/miner.h:g'     $(git grep -l miner)
 sed -i 's:miner\.cpp:node/miner.cpp:g' $(git grep -l miner)
 sed -i 's:MINER_H:NODE_MINER_H:g'      $(git grep -l MINER_H)
-END VERIFY SCRIPT-
    fa53e3a58c
  13. style: Sort file list after rename fa0739a7d3
  14. refactor: Replace validation.h include with forward-decl in miner.h fa4e09924b
  15. MarcoFalke force-pushed on Nov 16, 2021
  16. DrahtBot removed the label Needs rebase on Nov 16, 2021
  17. theStack commented at 12:33 PM on November 17, 2021: contributor

    Concept ACK

  18. DrahtBot cross-referenced this on Nov 24, 2021 from issue Move CBlockTreeDB to node/blockstorage by MarcoFalke
  19. theStack approved
  20. theStack commented at 6:58 PM on November 24, 2021: contributor

    Code-review ACK fa4e09924b11b0dc94e377005f86a83c09761265

  21. MarcoFalke merged this on Nov 26, 2021
  22. MarcoFalke closed this on Nov 26, 2021
  23. MarcoFalke deleted the branch on Nov 26, 2021
  24. bitcoin locked this on Nov 26, 2022
Contributors
MarcoFalkeDrahtBottheStack
Labels
Refactoring
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:53 UTC