On master (77a2f5d30c5ecb764b8a7c098492e1f5cdec90f0) a CI lint task log exceeds 20K lines.
This PR fixes this issue.
ci: Do not print `git log` for empty COMMIT_RANGE #23458
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:211107-range changing 1 files +6 −4-
hebasto commented at 3:24 PM on November 7, 2021: member
-
ci: Do not print `git log` for empty COMMIT_RANGE 095f07744c
-
katesalazar commented at 3:44 PM on November 7, 2021: contributor
That log you link is unfortunate. Concept ACK.
- DrahtBot added the label Tests on Nov 7, 2021
- hebasto cross-referenced this on Nov 7, 2021 from issue test: Enable SC2046 and SC2086 shellcheck rules by hebasto
-
fanquake commented at 2:11 AM on November 8, 2021: member
When / why did this start happening; did something change in the Cirrus?
-
hebasto commented at 5:54 AM on November 8, 2021: member
When / why did this start happening; did something change in the Cirrus?
As for now, the latest Cirrus logs are available for ce0913148b687310f2933397d0bbe4bd014c178e (2021-08-10), and CI behavior has not been changed since then.
I suspect, it was a flaw in 3c2478c38522c176e81befd4d991a259b09be063 (#20697), which remained unnoticed as no one cares about successful lint task logs :)
The issue was spotted while working on #23462.
-
MarcoFalke commented at 8:30 AM on November 8, 2021: member
cr ACK 095f07744cf500adc1f1587eb5b7a61df6e6b05f
- MarcoFalke merged this on Nov 8, 2021
- MarcoFalke closed this on Nov 8, 2021
-
MarcoFalke commented at 9:27 AM on November 8, 2021: member
Looks like this is working:
- hebasto deleted the branch on Nov 8, 2021
- sidhujag referenced this in commit b5b3bad3c6 on Nov 8, 2021
- bitcoin locked this on Nov 8, 2022
Contributors
Labels