util: Use FEATURE_LATEST for wallets created with bitcoin-wallet #23349

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:211024-bw-version changing 1 files +1 −1
  1. hebasto commented at 9:43 PM on October 24, 2021: member

    Since the 49d2374acf5845c5f760b5fd241482f292164147 commit was athored by jonasschnelli in 2016, the wallet version was bumped twice: in 2017 (bitcoin/bitcoin#11250) and in 2018 (bitcoin/bitcoin#12560).

    This PR bumps the version of wallets created with bitcoin-wallet offline tool.

    On master (04437ee721e66a7b76bef5ec2f88dd1efcd03b84) -- "walletversion": 139900:

    $ src/bitcoin-wallet -signet -wallet=211025-test-master create
    Topping up keypool...
    Wallet info
    ===========
    Name: 211025-test-master
    Format: sqlite
    Descriptors: yes
    Encrypted: no
    HD (hd seed available): yes
    Keypool Size: 6000
    Transactions: 0
    Address Book: 0
    $ src/bitcoin-cli -signet -rpcwallet=211025-test-master getwalletinfo
    {
      "walletname": "211025-test-master",
      "walletversion": 139900,
      "format": "sqlite",
      "balance": 0.00000000,
      "unconfirmed_balance": 0.00000000,
      "immature_balance": 0.00000000,
      "txcount": 0,
      "keypoolsize": 3000,
      "keypoolsize_hd_internal": 3000,
      "paytxfee": 0.00000000,
      "private_keys_enabled": true,
      "avoid_reuse": false,
      "scanning": false,
      "descriptors": true
    }
    

    With this PR -- "walletversion": 169900:

    $ src/bitcoin-wallet -signet -wallet=211025-test-pr create
    Topping up keypool...
    Wallet info
    ===========
    Name: 211025-test-pr
    Format: sqlite
    Descriptors: yes
    Encrypted: no
    HD (hd seed available): yes
    Keypool Size: 6000
    Transactions: 0
    Address Book: 0
    $ src/bitcoin-cli -signet -rpcwallet=211025-test-pr getwalletinfo
    {
      "walletname": "211025-test-pr",
      "walletversion": 169900,
      "format": "sqlite",
      "balance": 0.00000000,
      "unconfirmed_balance": 0.00000000,
      "immature_balance": 0.00000000,
      "txcount": 0,
      "keypoolsize": 3000,
      "keypoolsize_hd_internal": 3000,
      "paytxfee": 0.00000000,
      "private_keys_enabled": true,
      "avoid_reuse": false,
      "scanning": false,
      "descriptors": true
    }
    
  2. util: Use FEATURE_LATEST for wallets created with bitcoin-wallet 5b6b5ef5d1
  3. DrahtBot added the label Wallet on Oct 24, 2021
  4. hebasto cross-referenced this on Oct 26, 2021 from issue util: Add "importfromcoldcard" command to bitcoin-wallet tool by hebasto
  5. lsilva01 approved
  6. lsilva01 commented at 10:02 PM on October 26, 2021: contributor

    Code Review ACK 5b6b5ef

  7. fanquake requested review from achow101 on Oct 27, 2021
  8. stratospher commented at 6:57 PM on October 28, 2021: contributor

    ACK 5b6b5ef.

  9. rajarshimaitra approved
  10. hebasto requested review from meshcollider on Nov 14, 2021
  11. meshcollider commented at 12:18 AM on November 16, 2021: contributor

    Code review ACK 5b6b5ef5d178bea3c1b2f21e3bd05186312ea191

  12. meshcollider merged this on Nov 16, 2021
  13. meshcollider closed this on Nov 16, 2021

  14. hebasto deleted the branch on Nov 16, 2021
  15. sidhujag referenced this in commit 52cf54f1e4 on Nov 16, 2021
  16. bitcoin locked this on Nov 17, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:53 UTC