refactor: Make GenTxid boolean constructor private #23336

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2110-delGenTxid changing 9 files +13 −15

MarcoFalke commented at 10:36 AM on October 22, 2021: member

This boolean argument is either verbose (when used with a named arg) or unintuitive and dangerous (when used as a plain bool).

Fix that by making the constructor private.
remove unused CTxMemPool::info(const uint256& txid) faeb9a5753
Make GenTxid boolean constructor private fa4ec1c0bd
MarcoFalke added the label Refactoring on Oct 22, 2021
jnewbery commented at 11:19 AM on October 22, 2021: member

Concept ACK
laanwj commented at 12:44 PM on October 22, 2021: member

Code review ACK fa4ec1c0bdaef9f082a6661d7faf16149774e145 Checked that false→Txid and true→Wtxid is consistently changed.
glozow commented at 1:09 PM on October 22, 2021: member

code review ACK fa4ec1c0bdaef9f082a6661d7faf16149774e145

verified is_wtxid=false -> Txid, true -> Wtxid
jnewbery commented at 1:44 PM on October 22, 2021: member

Code review ACK fa4ec1c0bdaef9f082a6661d7faf16149774e145

Nice improvement. Thanks Marco!
MarcoFalke merged this on Oct 22, 2021
MarcoFalke closed this on Oct 22, 2021
MarcoFalke deleted the branch on Oct 22, 2021
sidhujag referenced this in commit 219b6d2926 on Oct 22, 2021
hebasto cross-referenced this on Oct 28, 2021 from issue qa: Intermittent failures in the psbt_wallet_tests/psbt_updater_test unit test by hebasto
hebasto commented at 6:51 AM on October 28, 2021: member

~It looks like this PR causes #23368~

UPDATE. See #23403.
bitcoin deleted a comment on Nov 2, 2021
bitcoin locked this on Nov 2, 2021

Contributors

Labels

Linked (view graph)

#23368 qa: Intermittent failures in the psbt_wallet_tests/psbt_updater_test unit test #23403 test: Fix segfault in the psbt_wallet_tests/psbt_updater_test