[22.x] build: explicitly disable libsecp256k1 openssl based tests #23315

pull fanquake wants to merge 1 commits into bitcoin:22.x from fanquake:22_x_disable_libsecp256k1_openssl_tests changing 1 files +1 −1

fanquake commented at 2:27 AM on October 20, 2021: member

Backport of #23314

These tests are failing when run against OpenSSL 3, and have been removed upstream, bitcoin-core/secp256k1#983, so disabled them for now to avoid make check failures.

Note that this will also remove warning output from our build, due to the use of deprecated OpenSSL API functions. See #23048.
fanquake added the label Build system on Oct 20, 2021
fanquake commented at 2:28 AM on October 20, 2021: member

cc @real-or-random @jonasnick
fanquake cross-referenced this on Oct 20, 2021 from issue build: explicitly disable libsecp256k1 openssl based tests by fanquake
laanwj added the label Backport on Oct 20, 2021

build: explicitly disable libsecp256k1 openssl based tests

These tests are failing when run against OpenSSL 3, and have been
removed upstream, https://github.com/bitcoin-core/secp256k1/pull/983, so
disabled them for now to avoid `make check` failures.

Note that this will also remove warning output from our build, due to
the use of deprecated OpenSSL API functions. See #23048.

Github-Pull: #23314
Rebased-From: d7524546abf1fa5be8e6317ee50585e966ae6b4c

e959b46aa9

fanquake force-pushed on Oct 20, 2021
fanquake commented at 11:52 PM on October 20, 2021: member

Updated to be a proper backport of #23314.
MarcoFalke commented at 7:18 AM on October 21, 2021: member

Can be moved to #23276?
fanquake commented at 7:20 AM on October 21, 2021: member

Can be moved to #23276?

I'd rather merge this now, to avoid check failures in the branch, than wait for #23276, which I assume will be a while longer yet.
MarcoFalke merged this on Oct 21, 2021
MarcoFalke closed this on Oct 21, 2021
MarcoFalke commented at 7:22 AM on October 21, 2021: member

ack
fanquake deleted the branch on Oct 21, 2021
knst referenced this in commit 6f1d324aa0 on Jul 27, 2022
knst cross-referenced this on Jul 27, 2022 from issue Merge bitcoin#23315: [22.x] build: explicitly disable libsecp256k1... by knst
UdjinM6 referenced this in commit a6e9e50845 on Jul 27, 2022
bitcoin locked this on Oct 30, 2022

Contributors

fanquake

MarcoFalke

Labels

Build system Backport

Linked (view graph)

#23048 Fix warnings building secp256k1 tests with openssl 3.0 #23276 [22.x] Backports for 22.x #23314 build: explicitly disable libsecp256k1 openssl based tests