doc: Extract FundTxDoc in rpcwallet #23172

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2110-docRpcWallet changing 1 files +34 −75
  1. MarcoFalke commented at 12:57 PM on October 4, 2021: member

    No need to duplicate the documentation for the same field(s) three times.

    Fix that by de-duplicating it for the fields: conf_target, estimate_mode, replaceable, and solving_data.

    Can be reviewed with --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space.

  2. doc: Extract FundTxDoc
    For the fields: conf_target, estimate_mode, replaceable, and solving_data.
    fafff132cf
  3. fanquake added the label Docs on Oct 4, 2021
  4. MarcoFalke commented at 1:00 PM on October 4, 2021: member

    Rendered diff: Screenshot from 2021-10-04 15-00-27

  5. MarcoFalke renamed this:
    doc: Extract FundTxDoc
    doc: Extract FundTxDoc in rpcwallet
    on Oct 4, 2021
  6. DrahtBot cross-referenced this on Oct 6, 2021 from issue wallet: allow psbtbumpfee to work with txs with external inputs by achow101
  7. DrahtBot cross-referenced this on Oct 6, 2021 from issue wallet: Allow users to specify input weights when funding a transaction by achow101
  8. DrahtBot commented at 12:17 PM on October 6, 2021: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #23202 (wallet: allow psbtbumpfee to work with txs with external inputs by achow101)
    • #23201 (wallet: Allow users to specify input weights when funding a transaction by achow101)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  9. fanquake approved
  10. fanquake commented at 5:27 AM on October 7, 2021: member

    ACK fafff132cf4e5c2950d28f63cb4320236d1a5495

  11. fanquake merged this on Oct 7, 2021
  12. fanquake closed this on Oct 7, 2021

  13. MarcoFalke deleted the branch on Oct 7, 2021
  14. sidhujag referenced this in commit a067ea61af on Oct 7, 2021
  15. fanquake cross-referenced this on Dec 1, 2021 from issue doc: Extract CreateTxDoc in rawtransaction by fanquake
  16. MarcoFalke referenced this in commit e7507f333b on Dec 1, 2021
  17. bitcoin locked this on Oct 30, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:53 UTC