Tracking issue for the follow up comments in #22904. It seems that PR has introduced lock contentions, and/or the checkqueue_tests are now behaving very poorly, with long runtimes and generating GBs of log output in some cases. See comments starting here: #22904 (comment).
lock contentions in checkqueue_tests after #22904 #23167
issue fanquake opened this issue on October 4, 2021-
fanquake commented at 3:12 AM on October 4, 2021: member
- fanquake added the label Bug on Oct 4, 2021
- fanquake cross-referenced this on Oct 4, 2021 from issue sync, log: inline lock contention logging macro to fix duration, improve BCLog::LogMsg() by jonatack
- jonatack cross-referenced this on Oct 7, 2021 from issue Disable lock contention logging in checkqueue_tests by jonatack
- hebasto cross-referenced this on Oct 30, 2021 from issue Avoid excessive lock contention in CCheckQueue::Add by hebasto
-
vasild commented at 4:30 PM on November 2, 2021: contributor
Both #23223 and #23397 alleviate this. Some primitive testing:
master(9e3f7dcaa2f89efff48d299132f4998bf701c264): withDEBUG_LOG_OUT: 6m28s, 2.2GB log withoutDEBUG_LOG_OUT: 6m10s, no logPR #23223 (6ae9f1cf9604227e9dfda1f6c91fc711d154362e): with
DEBUG_LOG_OUT: 1m3s, 5KB log withoutDEBUG_LOG_OUT: 1m1s, no logPR #23397 (5bcfd70a3b): with
DEBUG_LOG_OUT: 5m00s, 1.8GB log withoutDEBUG_LOG_OUT: 5m9s, no log(non-optimized debug builds)
- MarcoFalke referenced this in commit 3c4729a515 on Nov 2, 2021
- MarcoFalke closed this on Nov 2, 2021
- MarcoFalke referenced this in commit b4f647fa36 on Nov 29, 2021
- sidhujag referenced this in commit 537b8a836d on Nov 29, 2021
- PastaPastaPasta referenced this in commit c8374bd577 on Apr 7, 2022
- PastaPastaPasta referenced this in commit 25f8e062c0 on Apr 7, 2022
- PastaPastaPasta referenced this in commit 572737fff5 on Apr 7, 2022
- PastaPastaPasta referenced this in commit 22838d1b8c on Apr 11, 2022
- bitcoin locked this on Nov 2, 2022
