test: Remove unused and confusing main parameter from script_util #23120

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2109-testCleanupScript changing 1 files +39 −18

MarcoFalke commented at 1:49 PM on September 28, 2021: member

No description provided.

test: Remove unused and confusing main parameter from script_util

Bitcoin script opcodes are equal on all chains (main and test) anyway.

Can be reviewed with "--word-diff-regex=.".

fa46768059

test: pep-8 touched test

Can be reviewed with "--word-diff-regex=.".

fa54efda9b

theStack commented at 1:58 PM on September 28, 2021: contributor

Concept ACK
DrahtBot added the label Tests on Sep 28, 2021
DrahtBot commented at 6:08 PM on September 28, 2021: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #23118 (test: refactor: introduce script_util helper for creating P2PK scripts by theStack)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot cross-referenced this on Sep 28, 2021 from issue test: refactor: introduce `script_util` helper for creating P2PK scripts by theStack
vincenzopalazzo approved
vincenzopalazzo commented at 8:11 PM on September 28, 2021: none

ack https://github.com/bitcoin/bitcoin/pull/23120/commits/fa54efda9bc8f8f742dacbc3673516d88d9d601d
fanquake approved
fanquake commented at 1:19 AM on September 29, 2021: member

ACK fa54efda9bc8f8f742dacbc3673516d88d9d601d
MarcoFalke merged this on Sep 29, 2021
MarcoFalke closed this on Sep 29, 2021
MarcoFalke deleted the branch on Sep 29, 2021
sidhujag referenced this in commit 45cd2bfab9 on Sep 29, 2021
bitcoin locked this on Oct 30, 2022

Contributors

Labels