See #23116
test: Use assert_equal over assert for easier debugging #23117
pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2109-testAssertEq changing 1 files +30 −25-
MarcoFalke commented at 8:43 AM on September 28, 2021: member
-
test: Use assert_equal over assert for easier debugging fac5708afc
-
test: pep-8 fa8f3ba131
- MarcoFalke force-pushed on Sep 28, 2021
-
jonatack commented at 9:00 AM on September 28, 2021: contributor
Light code review ACK fa8f3ba131d5460275b52c08608ebad8195a420d
- hebasto approved
-
hebasto commented at 9:24 AM on September 28, 2021: member
ACK fa8f3ba131d5460275b52c08608ebad8195a420d, I have reviewed the code and it looks OK, I agree it can be merged.
- DrahtBot added the label Tests on Sep 28, 2021
- theStack approved
-
theStack commented at 12:13 PM on September 28, 2021: contributor
Code-review ACK fa8f3ba131d5460275b52c08608ebad8195a420d
Note that there are dozens of other instances in the functional test code where this substitution should be done:
$ cd ./test/functional $ git grep assert.*== | wc -l 153(though this number contains obviously also some false-positives)
- fanquake merged this on Sep 28, 2021
- fanquake closed this on Sep 28, 2021
- MarcoFalke deleted the branch on Sep 28, 2021
-
MarcoFalke commented at 12:28 PM on September 28, 2021: member
(though this number contains obviously also some false-positives)
Could be filed as a good first issue?
- theStack cross-referenced this on Sep 28, 2021 from issue test: replace bare asserts with assertion helpers (assert_equal() etc.) by theStack
- sidhujag referenced this in commit 38575c90dc on Sep 28, 2021
- danielabrozzoni cross-referenced this on Mar 9, 2022 from issue rpc: add rpc to get mempool txs spending specific prevouts by t-bast
- bitcoin locked this on Oct 30, 2022
