net: Avoid logging AlreadyHaveTx when disconnecting misbehaving peer #23042

1. 
   MarcoFalke commented at 7:24 AM on September 20, 2021: member

   There is no need to log AlreadyHaveTx for an inv when a peer is marked for disconnection due to sending that inv. In fact, I find it confusing that a block-relay-only connection calls AlreadyHaveTx at all. Also there is no need to call AddKnownTx when the peer is marked for disconnection.

2. net: Avoid logging AlreadyHaveTx when disconnecting misbehaving peer

   Can be reviewed with --color-moved=dimmed-zebra

   fa2662c293
3. MarcoFalke renamed this:
   net: Avoid logging AlreadyHaveTx when disconneting misbehaving peer
   net: Avoid logging AlreadyHaveTx when disconnecting misbehaving peer
   on Sep 20, 2021
4. MarcoFalke force-pushed on Sep 20, 2021
5. fanquake added the label P2P on Sep 20, 2021
6. MarcoFalke cross-referenced this on Sep 20, 2021 from issue net: Make m_mempool optional in PeerManager by sriramdvt
7. 
   naumenkogs commented at 10:28 AM on September 21, 2021: member

   ACK fa2662c293ec0aaa93092b59b6632f74729c4283

8. 
   jnewbery commented at 2:45 PM on September 21, 2021: member

   Code review ACK fa2662c293ec0aaa93092b59b6632f74729c4283

9. fanquake requested review from amitiuttarwar on Sep 23, 2021
10. 
    DrahtBot commented at 1:30 PM on September 24, 2021: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #22778 (net processing: Reduce resource usage for inbound block-relay-only connections by jnewbery)
    • #21160 (net/net processing: Move tx inventory into net_processing by jnewbery)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

11. DrahtBot cross-referenced this on Sep 24, 2021 from issue net processing: Reduce resource usage for inbound block-relay-only connections by jnewbery
12. DrahtBot cross-referenced this on Sep 25, 2021 from issue net/net processing: Move tx inventory into net_processing by jnewbery
13. 
    dunxen commented at 6:45 PM on October 5, 2021: contributor

    Concept and code review ACK fa2662c293ec0aaa93092b59b6632f74729c4283

    Makes sense to return earlier in this scenario. This took me on a nice little journey in P2P things getting some better context.

14. fanquake merged this on Oct 22, 2021
15. fanquake closed this on Oct 22, 2021

    ---

16. MarcoFalke deleted the branch on Oct 22, 2021
17. MarcoFalke cross-referenced this on Oct 22, 2021 from issue Some minor code changes to improve efficiency of processing TXs by rebroad
18. sidhujag referenced this in commit f61e177b1d on Oct 22, 2021
19. bitcoin locked this on Oct 30, 2022

Contributors

MarcoFalkenaumenkogsjnewberyDrahtBotdunxen

Review Requested
amitiuttarwar