This adds detection for various edge cases when decoding BIP32 extended pubkeys/privkeys, and tests them using the proposed https://github.com/bitcoin/bips/pull/921 BIP32 test vector 5.
Stricter BIP32 decoding and test vector 5 #22836
pull sipa wants to merge 1 commits into bitcoin:master from sipa:202108_bipvec5 changing 3 files +35 −1-
sipa commented at 4:03 PM on August 30, 2021: member
-
Stricter BIP32 decoding and test vector 5 56a42f10f4
- sipa cross-referenced this on Aug 30, 2021 from issue added test vector #5 for invalid extended keys by fametrano
- benthecarman cross-referenced this on Aug 30, 2021 from issue Add new invalid BIP 32 test vectors by benthecarman
- DrahtBot added the label Utils/log/libs on Aug 30, 2021
- darosior approved
-
darosior commented at 9:12 AM on September 1, 2021: member
utACK 56a42f10f452f0ac0e3e333646a8effcbebf6b30 -- Had to implement essentially the same fix in python-bip32.
-
fanquake commented at 10:14 AM on September 1, 2021: member
cc @kristapsk @Xekyo
- kristapsk approved
-
kristapsk commented at 2:14 PM on September 1, 2021: contributor
ACK 56a42f10f452f0ac0e3e333646a8effcbebf6b30. Checked that test vectors are the same as in BIP32 and that tests pass.
- fanquake merged this on Sep 2, 2021
- fanquake closed this on Sep 2, 2021
- sidhujag referenced this in commit 8fdd2cb327 on Sep 2, 2021
- kristapsk cross-referenced this on Nov 3, 2021 from issue BIP32 test vector 5 should be added to tests and checked by kristapsk
- kristapsk cross-referenced this on Feb 17, 2022 from issue Stricter BIP32 decoding and test vector 5 by kristapsk
- kristapsk referenced this in commit 83918a971d on Mar 2, 2022
- bitcoin locked this on Sep 2, 2022
Labels