Always call InvalidChainFound/InvalidBlockFound if ConnectBlock = false #2277

pull gavinandresen wants to merge 1 commits into bitcoin:master from gavinandresen:reorgfix changing 1 files +2 −4

gavinandresen commented at 10:03 PM on February 5, 2013: contributor

This fixes Matt's block-checker-tester for me.
Always call InvalidChainFound/InvalidBlockFound if ConnectBlock returns false 50bb929ad5
BitcoinPullTester commented at 1:17 AM on February 6, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/50bb929ad55ed066858aeebc38fd632756f6c2c6 for binaries and test log.
gavinandresen commented at 2:34 PM on February 6, 2013: contributor

Not the right fix according to @sipa -- instead, need to make sure that invalid blocks always return an invalid CValidationState.
sipa cross-referenced this on Feb 6, 2013 from issue Bugfix CValidationResult for BIP30 + add DoS by sipa
gavinandresen closed this on Feb 6, 2013
gavinandresen deleted the branch on Nov 4, 2013
bitcoin locked this on Sep 8, 2021

Contributors