It will still run cross-compilation to armhf, but run the binaries on the hardware itself, not qemu.
There shouldn't be any significant difference, other than maybe a slight speedup.
ci: Run arm task on arm64 hardware #22749
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2108-ciArm changing 1 files +4 −1-
MarcoFalke commented at 6:05 PM on August 19, 2021: member
-
MarcoFalke commented at 6:06 PM on August 19, 2021: member
See https://github.com/cirruslabs/cirrus-ci-docs/pull/905 for pre-merge documentation
-
Zero-1729 commented at 6:17 PM on August 19, 2021: contributor
Approach ACK
-
DrahtBot commented at 6:40 PM on August 19, 2021: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #20744 ([POC] Use std::filesystem. Remove Boost Filesystem & System by fanquake)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
ci: Run arm task on arm64 hardware fa35efa84b
- MarcoFalke force-pushed on Aug 19, 2021
- MarcoFalke force-pushed on Aug 19, 2021
- DrahtBot added the label Tests on Aug 19, 2021
- hebasto approved
-
hebasto commented at 10:42 PM on August 19, 2021: member
ACK fa23442ef1581e65f495460f5caae1f6b0582cbf.
Maybe the second commit should be mentioned in the PR description?
- DrahtBot cross-referenced this on Aug 19, 2021 from issue Use std::filesystem. Remove Boost Filesystem & System by fanquake
-
fanquake commented at 7:06 AM on August 20, 2021: member
Concept ACK
- MarcoFalke force-pushed on Aug 20, 2021
-
MarcoFalke commented at 7:20 AM on August 20, 2021: member
It looks like a full fresh build with functional tests takes 1 hour (24 minutes with cache).
Though, given that the functional tests on arm haven't found issues (https://github.com/bitcoin/bitcoin/pull/20072#issuecomment-703214314), we can skip them for an even faster build. So I've removed the second commit again.
-
MarcoFalke commented at 7:51 AM on August 20, 2021: member
The cached build without functional tests finished in 15 minutes, which is 10 minutes less than with qemu. :rocket:
- hebasto approved
-
hebasto commented at 7:52 AM on August 20, 2021: member
re-ACK fa35efa84bb614df9629076e45e9e974d9e940f6
- MarcoFalke merged this on Aug 20, 2021
- MarcoFalke closed this on Aug 20, 2021
- MarcoFalke deleted the branch on Aug 20, 2021
- real-or-random cross-referenced this on Aug 20, 2021 from issue General CI discussion by real-or-random
- sidhujag referenced this in commit efc333bfc7 on Aug 20, 2021
- sidhujag referenced this in commit d2f57e221f on Aug 22, 2021
- bitcoin locked this on Aug 20, 2022
Contributors
Labels