Fix build with Boost 1.77.0 #22713

pull sizeofvoid wants to merge 1 commits into bitcoin:master from sizeofvoid:boost-1770 changing 3 files +12 −0
  1. sizeofvoid commented at 4:38 AM on August 16, 2021: contributor

    BOOST_FILESYSTEM_C_STR changed to accept the path as an argument.

  2. sizeofvoid commented at 4:38 AM on August 16, 2021: contributor

    This will fix https://github.com/bitcoin/bitcoin/issues/22482

  3. fanquake commented at 4:44 AM on August 16, 2021: member

    Concept ACK.

    Even though we will hopefully be removing Boost Filesystem in master (#20744), fixing this is still needed, as we'll have to at least backport the change to 22.x and 0.21, as users building those branches being using newer Boost versions.

  4. bob-beck referenced this in commit 965435c36d on Aug 16, 2021
  5. bob-beck referenced this in commit 5ce49197de on Aug 16, 2021
  6. DrahtBot added the label Wallet on Aug 16, 2021
  7. MarcoFalke removed the label Wallet on Aug 16, 2021
  8. MarcoFalke added the label Build system on Aug 16, 2021
  9. MarcoFalke added the label Needs backport (0.21) on Aug 16, 2021
  10. MarcoFalke added the label Needs backport (22.x) on Aug 16, 2021
  11. MarcoFalke commented at 8:34 AM on August 16, 2021: member

    Looks like boost 1.77 was released with this, so Concept ACK. Didn't test with that boost version, though.

  12. DrahtBot commented at 8:41 AM on August 16, 2021: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    No conflicts as of last run.

  13. DrahtBot cross-referenced this on Aug 16, 2021 from issue Use std::filesystem. Remove Boost Filesystem & System by fanquake
  14. laanwj commented at 2:22 PM on August 16, 2021: member

    Concept ACK, I don't have that boost version to test with yet. Would be nice to see an independent confirmation that this solves the issue (maybe from @brad0 , the original reporter) before merging.

  15. brad0 commented at 11:54 PM on August 16, 2021: none

    Concept ACK, I don't have that boost version to test with yet. Would be nice to see an independent confirmation that this solves the issue (maybe from @brad0 , the original reporter) before merging.

    Yes, it is building fine now.

  16. in src/fs.cpp:246 in 5825876a23 outdated 
     241 | @@ -242,7 +242,11 @@ void ofstream::close()
 242 |  }
 243 |  #else // __GLIBCXX__
 244 |  
 245 | +#if BOOST_VERSION >= 107700
 246 | +static_assert(sizeof(BOOST_FILESYSTEM_C_STR(*fs::path())) == sizeof(wchar_t),
    laanwj commented at 12:24 PM on August 18, 2021:

    Wouldn't

    static_assert(sizeof(*BOOST_FILESYSTEM_C_STR(fs::path())) == sizeof(wchar_t),

    communicate the intent here better?

    hebasto commented at 9:46 AM on August 20, 2021:

    Agree.

    The member access operator has higher precedence than the indirection operator.

    sizeofvoid commented at 8:04 AM on August 24, 2021:

    Agree!

  17. hebasto commented at 7:58 AM on August 20, 2021: member

    Concept ACK.

  18. hebasto commented at 9:48 AM on August 20, 2021: member

    Tested 5825876a2339be72f205cc850cb3b28dbb10c412 using boost 1.77 from depends. @laanwj's comment should be addressed before merging.

  19. hebasto commented at 7:20 AM on August 24, 2021: member

    @sizeofvoid

    Could you address this comment to get this PR ready?

  20. sizeofvoid force-pushed on Aug 24, 2021
  21. hebasto commented at 8:19 AM on August 24, 2021: member

    @sizeofvoid

    Sorry, but it looks like you changed the wrong line in your recent push. No need to change the old static_assert. Only the new one should be fixed.

  22. sizeofvoid force-pushed on Aug 24, 2021
  23. sizeofvoid commented at 8:50 AM on August 24, 2021: contributor

    @sizeofvoid

    Sorry, but it looks like you changed the wrong line in your recent push. No need to change the old static_assert. Only the new one should be fixed.

    Ops, sorry. Fixed!

  24. hebasto commented at 9:05 AM on August 24, 2021: member

    ACK acb7aad27ec8a184808aa7905887e3b2c5d54e9c

  25. Fix build with Boost 1.77.0
    BOOST_FILESYSTEM_C_STR changed to accept the path as an argument
    acb7aad27e
  26. benthecarman approved
  27. benthecarman commented at 4:59 PM on August 25, 2021: contributor

    ACK acb7aad27ec8a184808aa7905887e3b2c5d54e9c

  28. fanquake approved
  29. fanquake commented at 8:16 AM on August 26, 2021: member

    ACK acb7aad27ec8a184808aa7905887e3b2c5d54e9c - tested the fix with Boost 1.77.0 and 1.71.0.

  30. fanquake merged this on Aug 26, 2021
  31. fanquake closed this on Aug 26, 2021
  32. fanquake cross-referenced this on Aug 26, 2021 from issue [22.x] rc3 backports by hebasto
  33. hebasto referenced this in commit 32e1424f84 on Aug 26, 2021
  34. hebasto commented at 11:52 AM on August 26, 2021: member

    Backported to 22.x in #22629.

  35. hebasto removed the label Needs backport (22.x) on Aug 26, 2021
  36. laanwj referenced this in commit 4a25e39624 on Aug 26, 2021
  37. hebasto referenced this in commit f5180d2317 on Aug 26, 2021
  38. hebasto cross-referenced this on Aug 26, 2021 from issue [0.21] 0.21.2rc2 backports by hebasto
  39. hebasto commented at 5:37 PM on August 26, 2021: member

    Backported to 0.21 in #22808.

  40. hebasto removed the label Needs backport (0.21) on Aug 26, 2021
  41. hebasto referenced this in commit d9b18c1290 on Aug 27, 2021
  42. fujicoin referenced this in commit f8c21deb34 on Aug 27, 2021
  43. brad0 cross-referenced this on Aug 28, 2021 from issue Failure to build with Boost 1.77 by brad0
  44. fanquake referenced this in commit 6ebb9d0e46 on Aug 28, 2021
  45. sidhujag referenced this in commit 81e8b88185 on Aug 28, 2021
  46. cho-m cross-referenced this on Sep 4, 2021 from issue boost boost-python3 boost-mpi 1.77.0 by bevanjkay
  47. barton2526 cross-referenced this on Sep 11, 2021 from issue Fix build with Boost 1.77.0 by barton2526
  48. str4d cross-referenced this on Dec 6, 2021 from issue Backport changes to `src/fs.{cpp,h}` by str4d
  49. Fabcien referenced this in commit 868322caea on Jan 6, 2022
  50. pkvk referenced this in commit cf85109bfc on Feb 9, 2022
  51. PastaPastaPasta referenced this in commit 92230c754b on Mar 13, 2022
  52. gwillen referenced this in commit 18cee94832 on Jul 27, 2022
  53. gwillen referenced this in commit 45898781ec on Aug 1, 2022
  54. apoelstra referenced this in commit e295862057 on Aug 14, 2022
  55. PiRK referenced this in commit c12bafcfed on Aug 16, 2022
  56. schancel referenced this in commit 0c207a7270 on Aug 17, 2022
  57. bitcoin locked this on Aug 26, 2022
Contributors
sizeofvoidfanquakeMarcoFalkeDrahtBotlaanwjbrad0hebastobenthecarman
Labels
Build system
Linked (view graph)
#20744 Use std::filesystem. Remove Boost Filesystem & System#22482 Failure to build with Boost 1.77#22629 [22.x] rc3 backports#22808 [0.21] 0.21.2rc2 backports
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:53 UTC