UPnP brings security problems #2268

issue tijsmaas opened this issue on February 3, 2013
  1. tijsmaas commented at 8:16 PM on February 3, 2013: none

    UPnP is used in the bitcoin implementation. How can I be sure that hackers are not able to use this technology to discover my devices and do more nasty stuff? Would it not be better to use other, more secure technologies?

    see http://www.upnp-hacks.org/upnp.html for more info.

    If you don't see this as an issue, then delete this Issue.

  2. luke-jr commented at 9:05 PM on February 3, 2013: member

    I'm not aware of any security problems with using UPnP.

  3. laanwj commented at 9:16 PM on February 3, 2013: member

    As I understood those vulnerabilities affect UPnP servers, not clients? In that case disabling it in bitcoin (which can already be done through a configuration option) makes you nothing safer, you need to disable it in your router.

    If there's also problems with the upnp client library used by bitcoin (miniupnpc) then sure it makea sense to disable building with it by default...

  4. Diapolo commented at 6:07 AM on February 4, 2013: none

    @laanwj I'd vote for checking if we are using the current version or if there were known security issues with our used one.

  5. laanwj commented at 7:36 AM on February 4, 2013: member

    Yes I already looked but haven't been able to find any problems with miniupnpc, and the linked site (upnp-hacks) even recommends using the miniupnpd (server) stack by the same vendor. Thus there is no software issue at our side. There's no problem with using UPnP when it is already available on a network.

    However, in general, with so many buggy UPnP implementations around in routers, there may be wisdom in recommending against enabling it in the router configuration. If you know what you're doing it's always safest to manually forward single ports. But this would be a documentation/wiki thing, not a software issue...

    So I'm closing this issue.

  6. laanwj closed this on Feb 4, 2013

  7. bitcoin locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:55 UTC