test: Set regtest.BIP66Height = 102 to speed up tests #22632

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2108-regtestFasterBip66 changing 5 files +11 −5

MarcoFalke commented at 10:07 AM on August 5, 2021: member

No need to waste time by forcing creation of more than 1000 blocks to get the benefits of being able to test BIP 66. Also, reducing the height makes it more likely that (third-party) tests are conforming to BIP 66, which is enforced on mainnet for all new blocks.
fanquake added the label Tests on Aug 5, 2021
test: Set regtest.BIP66Height = 102 to speed up tests fafe896a0b
MarcoFalke force-pushed on Aug 5, 2021
theStack commented at 11:04 AM on August 5, 2021: contributor

Strong Concept ACK
Zero-1729 commented at 12:03 PM on August 5, 2021: contributor

Concept ACK fafe896a0b870d85250927bd5374caf73d379468
DrahtBot commented at 3:22 PM on August 5, 2021: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #21862 (test: Set regtest.BIP65Height = 112 to speed up tests by MarcoFalke)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
GeneFerneau commented at 5:22 PM on August 5, 2021: none

Concept + code review ACK fafe896
DrahtBot cross-referenced this on Aug 5, 2021 from issue test: Set regtest.BIP65Height = 111 to speed up tests by MarcoFalke
brunoerg commented at 12:39 PM on August 6, 2021: contributor

Concept ACK
kristapsk approved
kristapsk commented at 3:44 PM on August 6, 2021: contributor

ACK fafe896a0b870d85250927bd5374caf73d379468. Full functional test suite showed few second speed incrase on my laptop (although I didn't do proper benchmarking with multiple runs, just single time ./test/functional/test_runner.py on current master vs this PR).
MarcoFalke commented at 3:49 PM on August 6, 2021: member

This should only affect the speed of test/functional/feature_dersig.py and no other test
theStack approved

theStack commented at 8:07 PM on August 6, 2021: contributor

Tested ACK fafe896a0b870d85250927bd5374caf73d379468

master branch:

$ time ./test/functional/feature_dersig.py
...
    0m15.29s real     0m11.55s user    0m05.72s system

PR branch:

$ time ./test/functional/feature_dersig.py
...
    0m03.97s real     0m01.42s user    0m01.34s system

🎉

Zero-1729 approved

Zero-1729 commented at 8:41 PM on August 6, 2021: contributor

tACK fafe896

Tested on macOS v11.4

Master

$ time ./test/functional/feature_dersig.py
...
./test/functional/feature_dersig.py  1.65s user 0.42s system

After Patch

$ time ./test/functional/feature_dersig.py
...
./test/functional/feature_dersig.py  0.37s user 0.15s system

0xB10C commented at 10:59 AM on August 8, 2021: contributor

crACK fafe896a0b870d85250927bd5374caf73d379468
hg333 approved
hg333 commented at 6:53 AM on August 10, 2021: contributor
tACK https://github.com/bitcoin/bitcoin/commit/fafe896a0b870d85250927bd5374caf73d379468

Tested on Ubuntu 20.04

Master branch:
```
$ time ./test/functional/feature_dersig.py 
...
real	0m23.470s
user	0m6.761s
sys	0m1.232s
```
PR branch:
```
$ time ./test/functional/feature_dersig.py 
...
real	0m3.051s
user	0m0.646s
sys	0m0.131s
```
laanwj commented at 2:17 PM on August 10, 2021: member

ACK fafe896a0b870d85250927bd5374caf73d379468
laanwj merged this on Aug 10, 2021
laanwj closed this on Aug 10, 2021
sidhujag referenced this in commit 56b6555e23 on Aug 15, 2021
MarcoFalke deleted the branch on Aug 22, 2021
bitcoin locked this on Aug 22, 2022

Contributors

Labels

test: Set regtest.BIP66Height = 102 to speed up tests #22632

Conflicts