[22.0] build: Version info ignores a tag #22623

issue hebasto opened this issue on August 4, 2021

hebasto commented at 12:35 PM on August 4, 2021: member

When building against a tagged commit (e.g., https://github.com/bitcoin/bitcoin/releases/tag/v22.0rc2) the version info should pull a tag rather a git commit hash.

Compare:

$ bin/bitcoind -version
Bitcoin Core version v0.21.0rc2
Copyright (C) 2009-2020 The Bitcoin Core developers

Please contribute if you find Bitcoin Core useful. Visit
<https://bitcoincore.org/> for further information about the software.
The source code is available from <https://github.com/bitcoin/bitcoin>.

This is experimental software.
Distributed under the MIT software license, see the accompanying file COPYING
or <https://opensource.org/licenses/MIT>

and

$ bin/bitcoind -version
Bitcoin Core version v22.0.0-g873fbc745d037ad43570f81e58334c397bc95477

hebasto added the label Bug on Aug 4, 2021
hebasto added the label Build system on Aug 4, 2021
MarcoFalke commented at 2:31 PM on August 4, 2021: member

Is this a bug? I assumed it was a desired change, but I might be mistaken.
hebasto commented at 2:34 PM on August 4, 2021: member

I assumed it was a desired change, but I might be mistaken.

Maybe it's my mistake? Did I miss a discussion of that change?
hebasto commented at 3:09 PM on August 4, 2021: member

The reason of such behavior is https://github.com/bitcoin/bitcoin/blob/873fbc745d037ad43570f81e58334c397bc95477/share/genbuild.sh#L23 where git rev-parse --is-inside-work-tree does not return true.
hebasto commented at 3:09 PM on August 4, 2021: member

cc @dongcarl
hebasto cross-referenced this on Aug 4, 2021 from issue guix: Build out of source tree by hebasto
hebasto cross-referenced this on Aug 5, 2021 from issue v22.0 testing by laanwj
hebasto commented at 10:15 PM on August 5, 2021: member

Fixed in #22625.
achow101 cross-referenced this on Aug 11, 2021 from issue guix: make git tag and commit known prior to building by achow101
achow101 commented at 1:55 AM on August 11, 2021: member

I have an alternative solution in #22680
dongcarl cross-referenced this on Aug 11, 2021 from issue clientversion: No suffix #if CLIENT_VERSION_IS_RELEASE by dongcarl
dongcarl commented at 11:42 PM on August 11, 2021: contributor

Fix for the underlying problem in: #22685
fanquake referenced this in commit 3facf0a8ae on Aug 16, 2021
fanquake commented at 4:22 AM on August 16, 2021: member

Fixed in #22685.
fanquake closed this on Aug 16, 2021
sidhujag referenced this in commit f287c95739 on Aug 20, 2021
PastaPastaPasta referenced this in commit 8504c5a139 on May 11, 2022
kwvg referenced this in commit 754ca58d38 on May 17, 2022
bitcoin locked this on Aug 18, 2022

Contributors

Labels

Linked (view graph)

#22625 guix: Build out of source tree #22634 v22.0 testing #22680 guix: make git tag and commit known prior to building #22685 clientversion: No suffix #if CLIENT_VERSION_IS_RELEASE