Updated the conversion of bytes<-> hex-string #22617

pull Saviour1001 wants to merge 1 commits into bitcoin:master from Saviour1001:binary-hex-conversion changing 2 files +2 −3
  1. Saviour1001 commented at 12:17 PM on August 3, 2021: none

    Regarding issue #22605 The functional test framework uses binascii in the following files:

    • test/functional/interface_rest.py
    • test/functional/rpc_createmultisig.py
    • test/functional/test_framework/bdb.py
    • test/functional/test_framework/blocktools.py
    • test/functional/test_framework/netutil.py

    The rpc_createmultisig.py and bitcoin-util-test.py don't require the binascii functions and could be run using the builtin and consistent <code>bytes</code> (class) methods. I have tested the other files and tried to replace binascii functions but wasn't able to replace them, they are the legitimate use cases of binascii.

  2. Updated the conversion of bytes<-> hex-string 0c8d4e125f
  3. fanquake added the label Tests on Aug 3, 2021
  4. MarcoFalke cross-referenced this on Aug 3, 2021 from issue use consistent bytes <-> hex-string conversions in functional test framework by theStack
  5. fanquake commented at 2:51 AM on August 4, 2021: member

    Closing in favour of #22619 after discussion in #22605.

  6. fanquake closed this on Aug 4, 2021
  7. bitcoin locked this on Aug 16, 2022
Contributors
Saviour1001fanquake
Labels
Tests
Linked (view graph)
#22605 use consistent bytes <-> hex-string conversions in functional test framework#22619 test: refactor: use consistent bytes <-> hex-string conversion in functional test framework
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:53 UTC