test: Add temporary sanitizer suppression implicit-signed-integer-truncation:netaddress.cpp #22584

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2107-testSupp changing 1 files +1 −0

MarcoFalke commented at 4:53 PM on July 29, 2021: member

This is required to unbreak the fuzzers while a fix is being worked on.

https://cirrus-ci.com/task/4787303177519104?logs=ci#L3020

netaddress.cpp:1190:18: runtime error: implicit conversion from type 'int' of value -1 (32-bit, signed) to type 'uint8_t' (aka 'unsigned char') changed the value to 255 (8-bit, unsigned)

test: Add temporary sanitizer suppression implicit-signed-integer-truncation:netaddress.cpp fa865287e5
DrahtBot added the label Tests on Jul 29, 2021
practicalswift commented at 6:19 PM on July 29, 2021: contributor

cr ACK fa865287e5f35e0a376785834e966dd202d2959e
jonatack cross-referenced this on Jul 29, 2021 from issue p2p: fix ubsan implicit conversion error in CSubNet::ToString() by jonatack
jonatack commented at 10:25 PM on July 29, 2021: contributor

ACK

Potentially a fix in #22586.
tryphe commented at 10:33 PM on July 29, 2021: contributor

untested ACK fa865287e5f35e0a376785834e966dd202d2959e

Prefer https://github.com/bitcoin/bitcoin/pull/22586
fanquake cross-referenced this on Jul 30, 2021 from issue Cirrus CI showed error in netaddress.cpp file when checking PR by lsilva01
lsilva01 approved
lsilva01 commented at 5:04 AM on July 30, 2021: contributor

ACK https://github.com/bitcoin/bitcoin/pull/22584/commits/fa865287e5f35e0a376785834e966dd202d2959e
MarcoFalke merged this on Jul 30, 2021
MarcoFalke closed this on Jul 30, 2021
MarcoFalke deleted the branch on Jul 30, 2021
sidhujag referenced this in commit 125f5e5aae on Aug 1, 2021
hebasto cross-referenced this on Aug 6, 2021 from issue [22.x] rc3 backports by hebasto
hebasto referenced this in commit a2b657da80 on Aug 6, 2021
hebasto commented at 7:48 AM on August 6, 2021: member

~Backported in #22629.~

UPDATE: #22629 (comment)
hebasto referenced this in commit b06865be34 on Aug 6, 2021
hebasto referenced this in commit 7f46c59136 on Aug 6, 2021
hebasto referenced this in commit 485b988de4 on Aug 7, 2021
hebasto referenced this in commit 3db1a0fe6c on Aug 9, 2021
hebasto referenced this in commit f9fab036e8 on Aug 9, 2021
hebasto referenced this in commit a6057945e5 on Aug 19, 2021
hebasto referenced this in commit 18cffd1e53 on Aug 20, 2021
hebasto referenced this in commit 9c6a0eb0d9 on Aug 20, 2021
bitcoin locked this on Aug 20, 2022

Contributors

Labels

Linked (view graph)

#22586 p2p: fix ubsan implicit conversion error in CSubNet::ToString()#22588 Cirrus CI showed error in netaddress.cpp file when checking PR #22629 [22.x] rc3 backports