scripted-diff: remove ResetI2PPorts() (revert e0a2b390c14) #22497

1. 
   vasild commented at 12:26 PM on July 19, 2021: contributor

   CAddrMan::ResetI2PPorts() was temporary. Remove it:

   • it has partially achieved its goal: probably ran on about half of the I2P nodes
   • it is hackish, deemed risky and two bugs where found in it: #22467 #22470

   -BEGIN VERIFY SCRIPT- git show e0a2b390c144e123e2fc8a289fdff36815476964 |git apply -R -END VERIFY SCRIPT-

   Fixes #22467 Fixes https://github.com/bitcoin/bitcoin/issues/22470

2. 
   vasild commented at 12:32 PM on July 19, 2021: contributor

   This PR supersedes (makes obsolete): #22468 https://github.com/bitcoin/bitcoin/pull/22471

3. scripted-diff: remove ResetI2PPorts() (revert e0a2b390c14)

   `CAddrMan::ResetI2PPorts()` was temporary. Remove it:
   * it has partially achieved its goal: probably ran on about half of the
     I2P nodes
   * it is hackish, deemed risky and two bugs where found in it
     https://github.com/bitcoin/bitcoin/issues/22467
     https://github.com/bitcoin/bitcoin/issues/22470
   
   -BEGIN VERIFY SCRIPT-
   git show e0a2b390c144e123e2fc8a289fdff36815476964 |git apply -R
   -END VERIFY SCRIPT-
   
   Fixes https://github.com/bitcoin/bitcoin/issues/22467
   Fixes https://github.com/bitcoin/bitcoin/issues/22470

   d4b67c8ebc
4. vasild force-pushed on Jul 19, 2021
5. 
   jonatack commented at 1:24 PM on July 19, 2021: contributor

   ACK d4b67c8ebc2bb7488bcaaccc3a801cdef1cf1678 per IRC discussions https://www.erisian.com.au/bitcoin-core-dev/log-2021-07-16.html#l-212 and https://www.erisian.com.au/bitcoin-core-dev/log-2021-07-19.html#l-210

6. DrahtBot added the label Refactoring on Jul 19, 2021
7. MarcoFalke added this to the milestone 22.0 on Jul 19, 2021
8. 
   laanwj commented at 6:01 PM on July 19, 2021: member

   ACK d4b67c8ebc2bb7488bcaaccc3a801cdef1cf1678

9. 
   MarcoFalke commented at 6:01 PM on July 19, 2021: member

   review ACK d4b67c8ebc2bb7488bcaaccc3a801cdef1cf1678 😲

   <details><summary>Show signature and timestamp</summary>

   Signature:

   -----BEGIN PGP SIGNED MESSAGE-----
   Hash: SHA512
   
   review ACK d4b67c8ebc2bb7488bcaaccc3a801cdef1cf1678 😲
   -----BEGIN PGP SIGNATURE-----
   
   iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
   pUg6zgv/ULh0hXhpAy7WL5DBG3Xn76U2HO3veHWtNVy64a4Djut74lceEGUsn+SA
   PD+5wM7jadH3O17vV/Pl6nh5YhZvgzgG1F2o+R+abK0Xu27agXI6F3utWr72GtvL
   tKEITPpCESRgmC4GpP38hoydi9tKM2fyqAm2wUReD0TGgIhJfNYS9p4nfbP+HdGf
   3h709FtciYB5ANT6SXZ4U3+qhYBdX5FsnT3Un+w6KzsyfBKhfY1BZcxK/bN7SDsj
   2uxeZ+a58/mNjlzQ2Lm+5X7PZRBGL9Q3+5RkImQj40KCxA16/r3WVIxNbiqLJO0p
   4RLUZ/A4lqUCw2i8+RL7NbU4rW61Xk5rT4FHhCrlL+qoG7xRtcvbAB6ZfU8EQaf1
   ybdNJ6v//MjtZFbxH899GiEpELq5m/qhhFoPlCtWeJ/hEq+aSz17yys8ZPFSV+cp
   1LUHstYGFQotCal8vS93+gIketmOfl/8e0W49wjGCTdIvF3xoe5Loh1aAW/IFquo
   AOWaqAtG
   =jJjT
   -----END PGP SIGNATURE-----
   

   Timestamp of file with hash 306e37b9caea4ca3333d35e458fad27fb95264adcc2faf9318af45c358d9e9cd -

   </details>

10. 
    laanwj commented at 6:08 PM on July 19, 2021: member

    Looks like #22496 is a similar PR, but it removes somewhat more, also RemoveInvalid, and prevents I2P addresses with non-zero ports from being inserted. Might be best to rebase it on top of this (which is a clean revert).

11. DrahtBot cross-referenced this on Jul 19, 2021 from issue addrman: Remove addrman hotfixes by jnewbery
12. 
    DrahtBot commented at 7:00 PM on July 19, 2021: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #22496 by jnewbery
    • #22471 by vasild
    • #22468 by vasild
    • #20233 by jnewbery

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

13. DrahtBot cross-referenced this on Jul 19, 2021 from issue addrman: reset I2P ports in all "new" buckets by vasild
14. DrahtBot cross-referenced this on Jul 19, 2021 from issue addrman: don't overwrite addr_info when resetting I2P ports by vasild
15. fanquake merged this on Jul 20, 2021
16. fanquake closed this on Jul 20, 2021

    ---

17. DrahtBot cross-referenced this on Jul 20, 2021 from issue addrman: Make consistency checks a runtime option by jnewbery
18. vasild deleted the branch on Jul 20, 2021
19. sidhujag referenced this in commit 2a336a660b on Jul 23, 2021
20. fanquake referenced this in commit 5cf28d5203 on Aug 3, 2021
21. Fabcien referenced this in commit 10df6b1378 on Feb 22, 2022
22. gwillen referenced this in commit 049058f5ae on Jun 1, 2022
23. bitcoin locked this on Aug 16, 2022

Contributors

vasildjonatacklaanwjMarcoFalkeDrahtBot

Milestone
22.0