[0.21] wallet: Do not iterate a directory if having an error while accessing it #22255

1. 
   luke-jr commented at 7:14 PM on June 15, 2021: member

   This change prevents infinite looping for, for example, system folders on Windows.

   Github-Pull: #21907 Rebased-From: 29c9e2c2d2015ade47ed4497926363dea3f9c59b

   Note: Trivial backport, but in a differently-named function in another file

2. wallet: Do not iterate a directory if having an error while accessing it

   This change prevents infinite looping for, for example, system folders
   on Windows.
   
   Github-Pull: #21907
   Rebased-From: 29c9e2c2d2015ade47ed4497926363dea3f9c59b

   7b0b201d10
3. DrahtBot added the label Backport on Jun 15, 2021
4. MarcoFalke added this to the milestone 0.21.2 on Jun 16, 2021
5. hebasto approved
6. 
   hebasto commented at 4:44 AM on June 28, 2021: member

   ACK 7b0b201d109b6240f114498fc1b94af9cb85f26e, I have reviewed the code and it looks OK, I agree it can be merged.

7. fanquake cross-referenced this on Jul 1, 2021 from issue wallet: Do not iterate a directory if having an error while accessing it by hebasto
8. 
   fanquake commented at 2:16 AM on July 1, 2021: member

   @promag @meshcollider @sipsorcery test / backport check?

9. MarcoFalke merged this on Jul 1, 2021
10. MarcoFalke closed this on Jul 1, 2021

    ---

11. 
    MarcoFalke commented at 6:42 AM on July 1, 2021: member

    review ACK. Didn't test on Windows

12. ComputerCraftr referenced this in commit 8ebd642212 on Aug 18, 2021
13. Ufakeimdope cross-referenced this on Sep 3, 2021 from issue Merge Bitcoin Core 0.21.2-rc2 by rnicoll
14. tcharding referenced this in commit 433ac6fcef on Jul 22, 2022
15. tcharding referenced this in commit 60a2417a8f on Aug 3, 2022
16. bitcoin locked this on Aug 18, 2022

Milestone
0.21.2