refactor: Make SetupServerArgs callable without NodeContext #22216

pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:pr/ipc-sargs changing 7 files +10 −9

ryanofsky commented at 10:02 PM on June 10, 2021: contributor

bitcoin-gui code needs to call SetupServerArgs but will not have a NodeContext object if it is communicating with an external bitcoin-node process, so this just passes ArgsManager directly.

This PR is part of the process separation project. The commit was first part of larger PR #10102.

Make SetupServerArgs callable without NodeContext

bitcoin-gui code needs to call SetupServerArgs but will not have a
NodeContext object if it is communicating with an external bitcoin-node
process.

493fb47c57

ryanofsky added this to the "In progress" column in a project

DrahtBot added the label GUI on Jun 10, 2021
DrahtBot added the label Refactoring on Jun 10, 2021
MarcoFalke commented at 7:18 AM on June 11, 2021: member

review ACK 493fb47c577b7564138c883a8f22cbac3619ce44
MarcoFalke removed the label GUI on Jun 11, 2021
MarcoFalke merged this on Jun 11, 2021
MarcoFalke closed this on Jun 11, 2021
MarcoFalke cross-referenced this on Jun 11, 2021 from issue multiprocess: Start using init makeNode, makeChain, etc methods by ryanofsky
kiminuo commented at 8:41 AM on June 11, 2021: contributor

late crACK 493fb47c577b7564138c883a8f22cbac3619ce44

Nice change.
sidhujag referenced this in commit f573613ea2 on Jun 11, 2021
hebasto commented at 7:20 PM on June 11, 2021: member

UPDATE: not only Windows -- #22227.

This PR causes a failed assertion on Windows 10 Pro (20H2, build 19042.1052):
hebasto cross-referenced this on Jun 11, 2021 from issue Regression in #22216 by hebasto

ryanofsky commented at 7:30 PM on June 11, 2021: contributor

Oh, sorry, I'm able to reproduce. Looking into it.

Stack trace at f66eceaecf464bfab5e19f3ca8fe680d8a6aa2e1

[#0](/github-metadata-backup-bitcoin-bitcoin/0/)  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
[#1](/github-metadata-backup-bitcoin-bitcoin/1/)  0x00007ffff3be8921 in __GI_abort () at abort.c:79
[#2](/github-metadata-backup-bitcoin-bitcoin/2/)  0x00007ffff3bd848a in __assert_fail_base (fmt=0x7ffff3d5f750 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", 
    assertion=assertion@entry=0x55555696d12f "\"node.args\" && check", file=file@entry=0x5555569afca6 "wallet/init.cpp", line=line@entry=127, 
    function=function@entry=0x5555569afe34 "auto WalletInit::Construct(NodeContext &)::(anonymous class)::operator()() const") at assert.c:92
[#3](/github-metadata-backup-bitcoin-bitcoin/3/)  0x00007ffff3bd8502 in __GI___assert_fail (assertion=0x55555696d12f "\"node.args\" && check", file=0x5555569afca6 "wallet/init.cpp", 
    line=127, function=0x5555569afe34 "auto WalletInit::Construct(NodeContext &)::(anonymous class)::operator()() const") at assert.c:101
[#4](/github-metadata-backup-bitcoin-bitcoin/4/)  0x0000555555f4f15a in WalletInit::Construct(NodeContext&) const::$_0::operator()() const (this=0x7fffffffce80) at wallet/init.cpp:127
[#5](/github-metadata-backup-bitcoin-bitcoin/5/)  0x0000555555f4ee4a in WalletInit::Construct (this=0x55555704b660 <_ZGR23g_wallet_init_interface_>, node=...) at wallet/init.cpp:127
[#6](/github-metadata-backup-bitcoin-bitcoin/6/)  0x0000555555a0b54b in AppInitInterfaces (node=...) at init.cpp:1058
[#7](/github-metadata-backup-bitcoin-bitcoin/7/)  0x0000555555bb67f5 in node::(anonymous namespace)::NodeImpl::baseInitialize (this=0x555557087950) at node/interfaces.cpp:81
[#8](/github-metadata-backup-bitcoin-bitcoin/8/)  0x0000555555797256 in BitcoinApplication::baseInitialize (this=0x7fffffffd400) at qt/bitcoin.cpp:289
[#9](/github-metadata-backup-bitcoin-bitcoin/9/)  0x000055555579abef in GuiMain (argc=2, argv=0x7fffffffdc18) at qt/bitcoin.cpp:633
[#10](/github-metadata-backup-bitcoin-bitcoin/10/) 0x00005555557916bf in main (argc=2, argv=0x7fffffffdc18) at qt/main.cpp:21

ryanofsky referenced this in commit d7f3b1af21 on Jun 11, 2021
ryanofsky cross-referenced this on Jun 11, 2021 from issue Fix gui segfault caused by bitcoin/bitcoin#22216 by ryanofsky
hebasto referenced this in commit a8c8dbc98f on Jun 11, 2021
sidhujag referenced this in commit f194dc2845 on Jun 12, 2021
rebroad referenced this in commit 352d3fcc13 on Jun 23, 2021
rebroad referenced this in commit 7cea05d4e7 on Jun 28, 2021
hebasto referenced this in commit 75f5d74833 on Jul 6, 2021
ryanofsky moved this from the "In progress" to the "Done" column in a project

janus referenced this in commit 64af71c62b on Oct 29, 2021
gwillen referenced this in commit 25981aeceb on Jun 1, 2022
bitcoin locked this on Aug 16, 2022

Contributors

Labels

Linked (view graph)

#10102 Multiprocess bitcoin #22219 multiprocess: Start using init makeNode, makeChain, etc methods #22227 Regression in #22216 #28722 Multiprocess tracking issue