This tiny PR adds a sanity check to the bitcoin-tx tool w.r.t. to tx output values specified by the user: the parsing function ExtractAndValidateValue is extended to throw if the amount is not in range [0, MAX_MONEY].
master:
$ bitcoin-tx -create outdata=21000001:affe
0200000000010021fd5ff0750700046a02affe00000000
PR branch:
$ bitcoin-tx -create outdata=21000001:affe
error: TX output value out of range
Concept ACK
Non-blocking thought: I guess it could be argued that bool ParseMoney(const std::string& str, CAmount& nRet) should return false if !MoneyRange(nRet).
Can we see a use case for ParseMoney where it shouldn't be immediately followed by a MoneyRange check?
Agree with @practicalswift that neither fees nor fee rates larger than MAX_MONEY make any sense.
See also:
Finally, ParseMoney could be changed to return std::optional<CAmount>.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.