wallet: Do not load external signers wallets when unsupported #22173

1. 
   achow101 commented at 5:54 PM on June 6, 2021: member

   When external signer support is not compiled, do not load external signer wallets.

   Alternative to #22168.

2. Do not load external signers wallets when unsupported

   When external signer support is not compiled, do not load external
   signer wallets.

   e60cd26ad4
3. 
   hebasto commented at 5:56 PM on June 6, 2021: member

   Is this a fix for #21919?

4. 
   achow101 commented at 6:02 PM on June 6, 2021: member

   Is this a fix for #21919?

   It would seem so.

5. DrahtBot added the label Wallet on Jun 6, 2021
6. 
   promag commented at 8:26 PM on June 7, 2021: member

   Tested ACK e60cd26ad46559770ad84d2959c9a1742ae8b7a6.

7. meshcollider added this to the milestone 22.0 on Jun 9, 2021
8. 
   meshcollider commented at 2:13 AM on June 9, 2021: contributor

   Code review ACK e60cd26ad46559770ad84d2959c9a1742ae8b7a6

9. meshcollider merged this on Jun 9, 2021
10. meshcollider closed this on Jun 9, 2021

    ---

11. meshcollider cross-referenced this on Jun 9, 2021 from issue wallet: bitcoind fails to auto-load a non-empty external-signer wallet by hebasto
12. sidhujag referenced this in commit 15f3ffa838 on Jun 9, 2021
13. Sjors cross-referenced this on Jun 10, 2021 from issue Enable external signer support by default, reduce #ifdef by Sjors
14. 
    Sjors commented at 4:30 PM on June 15, 2021: member

    Thanks. I think the reason why I missed this in #16546 is that I only tested a node downgrade. Earlier versions of Bitcoin Core will stop when they see an unrecognised wallet flag.

15. gwillen referenced this in commit 0fe87c64ad on Jun 1, 2022
16. bitcoin locked this on Aug 16, 2022

Contributors

achow101hebastopromagmeshcolliderSjors

Milestone
22.0