rpc: add period_start to version bits statistics #22016

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2021/05/versionbits_period_start changing 2 files +3 −0

Sjors commented at 3:51 PM on May 21, 2021: member

This PR adds period_start to the softfork statistics.

This makes it easier to draw green squares.

Admittedly this is trivial to calculate: $height - ($height mod $period)
fanquake added the label RPC/REST/ZMQ on May 21, 2021
Sjors force-pushed on May 21, 2021
Sjors commented at 4:28 PM on May 21, 2021: member

Alternatively we could add retarget_period_start to the main getblockchaininfo dictionary.
DrahtBot commented at 3:51 AM on May 22, 2021: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #23508 (Add getdeploymentinfo RPC by ajtowns)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot cross-referenced this on May 22, 2021 from issue RPC/blockchain: getblockchaininfo: Include versionbits signalling details during LOCKED_IN by luke-jr
luke-jr commented at 11:50 PM on June 11, 2021: member

Could also do height - elapsed? At the very least, I think it'd be better to keep it out of BIP9Stats and just do the math in the RPC interface...
Sjors force-pushed on Jun 16, 2021
Sjors commented at 9:46 AM on June 16, 2021: member

@luke-jr good point, done. It makes the change a lot smaller and limited to RPC code.
luke-jr referenced this in commit 7c2cd06532 on Jun 27, 2021
DrahtBot added the label Needs rebase on Jul 21, 2021
Sjors commented at 8:16 AM on July 21, 2021: member

Rebased after #21934
Sjors force-pushed on Jul 21, 2021
DrahtBot removed the label Needs rebase on Jul 21, 2021
DrahtBot cross-referenced this on Aug 25, 2021 from issue doc: Fix RPC result documentation by MarcoFalke
DrahtBot added the label Needs rebase on Sep 23, 2021
Sjors force-pushed on Sep 23, 2021
DrahtBot removed the label Needs rebase on Sep 23, 2021
luke-jr referenced this in commit d6d1a1b47e on Oct 10, 2021
DrahtBot cross-referenced this on Nov 14, 2021 from issue Add getdeploymentinfo RPC by ajtowns
DrahtBot cross-referenced this on Nov 18, 2021 from issue scripted-diff: Use clang-tidy syntax for C++ named arguments by MarcoFalke
DrahtBot cross-referenced this on Dec 8, 2021 from issue scripted-diff: Use named args in RPC docs by MarcoFalke
DrahtBot added the label Needs rebase on Dec 9, 2021
rpc: add period_start to version bits statistics 1898b9be12
Sjors force-pushed on Dec 9, 2021
DrahtBot removed the label Needs rebase on Dec 9, 2021
laanwj commented at 9:22 PM on December 15, 2021: member

Do we need to reconsider this after #23508?
Sjors commented at 5:34 AM on December 16, 2021: member

I might just rebase it after that, yes.
DrahtBot added the label Needs rebase on Jan 28, 2022
DrahtBot commented at 8:41 AM on January 28, 2022: contributor



🐙 This pull request conflicts with the target branch and needs rebase.

<sub>Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".</sub>
Sjors commented at 9:13 AM on January 28, 2022: member

Green squares have already been made trivial with #23508, so closing this.
Sjors closed this on Jan 28, 2022
bitcoin locked this on Jan 28, 2023

Contributors

Labels

RPC/REST/ZMQ Needs rebase

rpc: add period_start to version bits statistics #22016

Conflicts