Document that `ser_float_to_uint32` is not the inverse of `ser_uint32_to_float` #21964

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:document-serialization-gotcha changing 1 files +12 −0
  1. practicalswift commented at 6:40 PM on May 16, 2021: contributor

    Document that ser_float_to_uint32 is not the inverse of ser_uint32_to_float.

    Document that ser_double_to_uint64 is not the inverse of ser_uint64_to_double.

    Document that the only supported round-trip is: floating-point → integral → floating-point.

    Context: #21929 (comment)

  2. doc: Document that ser_float_to_uint32 is not the inverse of ser_uint32_to_float 474734bb69
  3. DrahtBot cross-referenced this on May 17, 2021 from issue Remove double serialization; use software encoder for fee estimation by sipa
  4. DrahtBot commented at 3:46 AM on May 17, 2021: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #21981 (Remove unused float serialization by MarcoFalke)
    • #21966 (Software float encoding by sipa)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. sipa commented at 5:12 AM on May 17, 2021: member

    See also #21966 for an alternative that makes float/double serialization exactly specified and independent of platform.

  6. DrahtBot cross-referenced this on May 17, 2021 from issue Remove unused float serialization by MarcoFalke
  7. practicalswift commented at 10:07 PM on May 18, 2021: contributor

    Closing in favour of #21966 which removes the need for this documentation :)

  8. practicalswift closed this on May 18, 2021

  9. bitcoin locked this on Aug 18, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC