qmake breaks upon pre-defined system wide --param options #2196

issue tomboy-64 opened this issue on January 22, 2013
  1. tomboy-64 commented at 3:25 PM on January 22, 2013: none

    Gentoo allows pre-definition of C(XX)FLAGS. Now if those CFLAGS contain one or more --param options, qmake filters out the --param of QMAKE_CXXFLAGS *= -fstack-protector-all --param ssp-buffer-size=1 QMAKE_LFLAGS *= -fstack-protector-all --param ssp-buffer-size=1 and tries to give g++ instead "ssp-buffer-size=1" as an option.

    Solution: enclose --param ssp-buffer-size=1 in "", like so:

    --- bitcoin-qt.pro.old 2012-12-10 15:47:37.000000000 +0100 +++ bitcoin-qt.pro 2013-01-22 15:33:45.000000000 +0100 @@ -33,8 +33,8 @@

    !win32 {

    for extra security against potential buffer overflows: enable GCCs Stack Smashing Protection

    -QMAKE_CXXFLAGS *= -fstack-protector-all --param ssp-buffer-size=1 -QMAKE_LFLAGS *= -fstack-protector-all --param ssp-buffer-size=1 +QMAKE_CXXFLAGS *= -fstack-protector-all "--param ssp-buffer-size=1" +QMAKE_LFLAGS *= -fstack-protector-all "--param ssp-buffer-size=1"

    We need to exclude this for Windows cross compile with MinGW 4.2.x, as it will result in a non-working executable!

    This can be enabled for Windows, when we switch to MinGW >= 4.4.x.

    }

  2. laanwj commented at 3:52 PM on January 22, 2013: member

    Can you make a pull request?

  3. tomboy-64 commented at 10:20 PM on January 23, 2013: none

    Done.

    #2211

  4. laanwj closed this on Oct 25, 2013

  5. sidhujag referenced this in commit 61abc9ca3a on Jul 31, 2018
  6. bitcoin locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:55 UTC