docs: improve make with parallel jobs description. #21942

pull klementtan wants to merge 1 commits into bitcoin:master from klementtan:docs/improve-jX changing 6 files +6 −6
  1. klementtan commented at 12:25 PM on May 13, 2021: contributor

    Changed use -jX here for parallelism to use "-j N" for N parallel jobs

    Rationale: In my opinion use -jX here for parallelism is quite ambiguous as it could be perceived as a single option without any argument. Ie running:

    make -jX
    

    Embarrassingly this caused me to be stuck for quite a long time until I opened the help menu for make but if I am the only one who faced this issue I would be happy to close this PR.

  2. fanquake added the label Docs on May 13, 2021
  3. laanwj commented at 3:17 PM on May 13, 2021: member

    ACK, agree that this is a clearer wording.

  4. DrahtBot commented at 3:19 PM on May 13, 2021: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #20610 (doc: update for NetBSD 9.1, add GUI Build Instructions by jarolrod)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. jarolrod commented at 5:37 PM on May 13, 2021: member
  6. DrahtBot cross-referenced this on May 13, 2021 from issue doc: update for NetBSD 9.1, add GUI Build Instructions by jarolrod
  7. docs: improve make with parallel jobs description. 07bc22ef10
  8. klementtan force-pushed on May 14, 2021
  9. klementtan commented at 12:46 AM on May 14, 2021: contributor

    Concept ACK

    Two more places where you might want to add a similar note:

    Thanks for pointing that out. Updated the PR according to this.

  10. jarolrod commented at 12:50 AM on May 14, 2021: member

    ACK 07bc22ef105dee3c6c465a3ef31e52fd198e786d

  11. MarcoFalke merged this on May 14, 2021
  12. MarcoFalke closed this on May 14, 2021

  13. sidhujag referenced this in commit b1f415ee9d on May 14, 2021
  14. jarolrod cross-referenced this on Jun 23, 2021 from issue doc: Install WSL on non-system drive and compile Bitcoin by nourou4them
  15. gwillen referenced this in commit 251048913c on Jun 1, 2022
  16. klementtan deleted the branch on Jun 5, 2022
  17. bitcoin locked this on Jun 5, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC