Logically based on #21940
Currently the fuzz test may spend a long time generating random numbers:
Fix that by calling const member functions only once.
Hopefully fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34224
fuzz: Call const member functions in addrman fuzz test only once #21941
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2105-fuzzAddrConst changing 1 files +9 −14-
MarcoFalke commented at 10:17 AM on May 13, 2021: member
- DrahtBot added the label Tests on May 13, 2021
-
DrahtBot commented at 3:22 PM on May 13, 2021: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
No conflicts as of last run.
- DrahtBot cross-referenced this on May 13, 2021 from issue p2p, rpc: enable GetAddr, GetAddresses, and getnodeaddresses by network by jonatack
- DrahtBot cross-referenced this on May 13, 2021 from issue addrman: Make consistency checks a runtime option by jnewbery
-
practicalswift commented at 11:46 AM on May 15, 2021: contributor
Concept ACK
- MarcoFalke marked this as ready for review on Jun 13, 2021
- DrahtBot added the label Needs rebase on Jun 13, 2021
-
fuzz: Call const member functions in addrman fuzz test only once faf7623106
- MarcoFalke force-pushed on Jun 13, 2021
-
MarcoFalke commented at 11:54 AM on June 13, 2021: member
Rebased to remove the logical dependency. This is still logically based on #21940, but not strictly required for merging.
- DrahtBot removed the label Needs rebase on Jun 13, 2021
-
practicalswift commented at 4:55 PM on June 13, 2021: contributor
cr ACK faf7623106af2e106a3d9777d714d6afeb2bbd83: touches only
src/test/fuzz/addrman.cpp - MarcoFalke merged this on Jun 13, 2021
- MarcoFalke closed this on Jun 13, 2021
- MarcoFalke deleted the branch on Jun 13, 2021
- hebasto cross-referenced this on Jun 14, 2021 from issue refactor: Make CAddrMan::cs non-recursive by hebasto
- gwillen referenced this in commit 8923cd37e5 on Jun 1, 2022
- bitcoin locked this on Aug 16, 2022
